Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/1] package/gcc: pass -Wno-error to debug builds
Date: Tue, 7 Apr 2020 22:32:36 +0200	[thread overview]
Message-ID: <20200407203236.GA29898@scaer> (raw)
In-Reply-To: <20200407192622.46151-1-james.hilliard1@gmail.com>

James, All,

On 2020-04-07 13:26 -0600, James Hilliard spake thusly:
> Fixes:
> ../../../../libsanitizer/libbacktrace/../../libbacktrace/elf.c:772:21: error: ?st.st_mode? may be used uninitialized in this function [-Werror=maybe-uninitialized]
>    return S_ISLNK (st.st_mode);
>                      ^
> Upstream has been unable to reproduce/fix properly, details:
> https://gcc.gnu.org/legacy-ml/gcc-patches/2019-03/threads.html#00827
> 
> Upstream recommends passing -Wno-error as a workaround, see:
> https://gcc.gnu.org/pipermail/gcc-patches/2019-April/519867.html
> 
> Reviewed-by: Romain Naour <romain.naour@gmail.com>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

I added a reproducing defconfig, extended the commit log a little bit,
and pushed to master, thanks.

Regards,
Yann E. MORIN.

> ---
> Changes v2 -> v3:
>   - add more details to message
> Changes v1 -> v2:
>   - add comment from Yocto recipes
> ---
>  package/gcc/gcc.mk | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/package/gcc/gcc.mk b/package/gcc/gcc.mk
> index 524ca83db0..fe7167b2f3 100644
> --- a/package/gcc/gcc.mk
> +++ b/package/gcc/gcc.mk
> @@ -100,6 +100,11 @@ HOST_GCC_COMMON_CONF_ENV = \
>  GCC_COMMON_TARGET_CFLAGS = $(TARGET_CFLAGS)
>  GCC_COMMON_TARGET_CXXFLAGS = $(TARGET_CXXFLAGS)
>  
> +# used to fix ../../../../libsanitizer/libbacktrace/../../libbacktrace/elf.c:772:21: error: ?st.st_mode? may be used uninitialized in this function [-Werror=maybe-uninitialized]
> +ifeq ($(BR2_ENABLE_DEBUG),y)
> +GCC_COMMON_TARGET_CFLAGS += -Wno-error
> +endif
> +
>  # Propagate options used for target software building to GCC target libs
>  HOST_GCC_COMMON_CONF_ENV += CFLAGS_FOR_TARGET="$(GCC_COMMON_TARGET_CFLAGS)"
>  HOST_GCC_COMMON_CONF_ENV += CXXFLAGS_FOR_TARGET="$(GCC_COMMON_TARGET_CXXFLAGS)"
> -- 
> 2.20.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2020-04-07 20:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-07 19:26 [Buildroot] [PATCH v3 1/1] package/gcc: pass -Wno-error to debug builds James Hilliard
2020-04-07 20:32 ` Yann E. MORIN [this message]
2020-04-08 14:34 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200407203236.GA29898@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox