From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] core/show-info: do not show install types for host packages
Date: Fri, 10 Apr 2020 21:50:18 +0200 [thread overview]
Message-ID: <20200410195018.GI29898@scaer> (raw)
In-Reply-To: <20200409205855.21194-1-yann.morin.1998@free.fr>
All,
On 2020-04-09 22:58 +0200, Yann E. MORIN spake thusly:
> By their very nature, host packages have no target, staging, or
> images install steps; they have a single install step, that is
> always performed.
>
> However, we currently report those three types of install, which
> is misleading at best, and really incorrect.
>
> If we were to report any install type for host package, that would
> be a single one, and it would always be true.
>
> So, do not report any install type for host packages, as it does
> not make sense to report anything that is always true.
>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Vadim Kochan <vadim4j@gmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Cc: Arnout Vandecappelle <arnout@mind.be>
> ---
> package/pkg-utils.mk | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/package/pkg-utils.mk b/package/pkg-utils.mk
> index d324934dba..14101fcc2a 100644
> --- a/package/pkg-utils.mk
> +++ b/package/pkg-utils.mk
> @@ -112,9 +112,11 @@ define _json-info-pkg-details
> "version": "$($(1)_DL_VERSION)",
> "licenses": "$($(1)_LICENSE)",
> "dl_dir": "$($(1)_DL_SUBDIR)",
> - "install_target": $(call yesno-to-bool,$($(1)_INSTALL_TARGET)),
> - "install_staging": $(call yesno-to-bool,$($(1)_INSTALL_STAGING)),
> - "install_images": $(call yesno-to-bool,$($(1)_INSTALL_IMAGES)),
> + $(if $(filter target,$($(1)_TYPE)), \
> + "install_target": $(call yesno-to-bool,$($(1)_INSTALL_TARGET))$(comma) \
> + "install_staging": $(call yesno-to-bool,$($(1)_INSTALL_STAGING))$(comma) \
> + "install_images": $(call yesno-to-bool,$($(1)_INSTALL_IMAGES))$(comma) \
> + )
There is more to it than just this, so I'll be sending a revised series
about show-info.
Patch marked as changes requestd in patchwork.
Regards,
Yann E. MORIN.
> "downloads": [
> $(foreach dl,$(sort $($(1)_ALL_DOWNLOADS)),
> {
> --
> 2.20.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2020-04-10 19:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 20:58 [Buildroot] [PATCH] core/show-info: do not show install types for host packages Yann E. MORIN
2020-04-10 19:50 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200410195018.GI29898@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox