From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] azure-iot-sdk-c: fix missing libraries
Date: Mon, 13 Apr 2020 15:51:27 +0200 [thread overview]
Message-ID: <20200413155127.763bbdcc@windsurf.home> (raw)
In-Reply-To: <20190923115206.4468-1-stephan.hoffmann@ext.grandcentrix.net>
On Mon, 23 Sep 2019 13:52:06 +0200
<stephan.hoffmann@ext.grandcentrix.net> wrote:
> From: Stephan Hoffmann <stephan.hoffmann@ext.grandcentrix.net>
>
> libparson.so and libumqtt.so.1 are missing.
>
> The package builds libparson, but does not install it.
> It also does not install the symlinks for libumqtt.so.1.1.11.
>
> Signed-off-by: Stephan Hoffmann <stephan.hoffmann@ext.grandcentrix.net>
> ---
> package/azure-iot-sdk-c/azure-iot-sdk-c.mk | 24 +++++++++++++++++-----
> 1 file changed, 19 insertions(+), 5 deletions(-)
So I finally applied this, but after doing quite a bit of rework. For
example, your patch was not correct as it was creating the .so symlinks
unconditionally, even when BR2_STATIC_LIBS=y, i.e even when static
libraries are used. Another issue is that you were reformatting the
list of libraries to have one per-line, in the same patch. And you were
fixing the libparson and libumqtt issues in the same patch.
So, I first applied three preparation commits:
https://git.buildroot.org/buildroot/commit/?id=c71030f0fab49be4061fb999a8eabe4190f1f18d
https://git.buildroot.org/buildroot/commit/?id=59de11b0476699ddeb2cbcd30a524b849249956a
https://git.buildroot.org/buildroot/commit/?id=43822bb6db8851df4d6568622b58196895028f91
Then, I applied your fix for libumqtt.so:
https://git.buildroot.org/buildroot/commit/?id=570dd0c31b2149cd913866eb6777caa4a1b05a56
And your fix for libparson.so:
https://git.buildroot.org/buildroot/commit/?id=94120fd7c71881e7b3963d5db27802241d9eeed2
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-04-13 13:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 11:52 [Buildroot] [PATCH] azure-iot-sdk-c: fix missing libraries stephan.hoffmann at ext.grandcentrix.net
2020-04-13 13:51 ` Thomas Petazzoni [this message]
2020-05-06 4:59 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413155127.763bbdcc@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox