Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/libgit2: Bump to version 1.0.0
Date: Wed, 15 Apr 2020 22:32:58 +0200	[thread overview]
Message-ID: <20200415223258.2d5d406c@windsurf.home> (raw)
In-Reply-To: <20200414091439.25465-1-nicolas.cavallari@green-communications.fr>

On Tue, 14 Apr 2020 11:14:39 +0200
Nicolas Cavallari <nicolas.cavallari@green-communications.fr> wrote:

> diff --git a/package/libgit2/Config.in b/package/libgit2/Config.in
> index 53ba4d4245..02c51448ff 100644
> --- a/package/libgit2/Config.in
> +++ b/package/libgit2/Config.in
> @@ -1,5 +1,7 @@
>  config BR2_PACKAGE_LIBGIT2
>  	bool "libgit2"
> +	depends on !BR2_STATIC_LIBS # libhttpparser

This requires the addition of a Config.in comment.

> -LIBGIT2_VERSION = 0.28.4
> -LIBGIT2_SITE = $(call github,libgit2,libgit2,v$(LIBGIT2_VERSION))
> -LIBGIT2_LICENSE = GPL-2.0 with linking exception
> +LIBGIT2_VERSION = 1.0.0
> +LIBGIT2_SITE = https://github.com/libgit2/libgit2/releases/download/v1.0.0

Instead of hardcoding v1.0.0 in the URL, use $(LIBGIT2_VERSION)

> +LIBGIT2_LICENSE = GPL-2.0 with linking exception, BSD 4-clause variant (wildmatch), MIT (sha1)

But here is the part that made me not apply the patch: this BSD
4-clause variant thing. The license text is at
https://github.com/libgit2/libgit2/blob/master/COPYING#L995 and it
doesn't seem to be a license known at https://spdx.org/licenses/. I'm
not sure how to properly encode it.

Yann, Arnout, any suggestion?

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2020-04-15 20:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-14  9:14 [Buildroot] [PATCH 1/1] package/libgit2: Bump to version 1.0.0 Nicolas Cavallari
2020-04-15 20:32 ` Thomas Petazzoni [this message]
2020-04-15 21:16   ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200415223258.2d5d406c@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox