public inbox for buildroot@busybox.net
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/modem-manager: use libqmi and libmbim if they are selected
Date: Sun, 19 Apr 2020 23:00:56 +0200	[thread overview]
Message-ID: <20200419230056.7df2d309@windsurf.home> (raw)
In-Reply-To: <20191104124844.8112-1-unixmania@gmail.com>

Hello Carlos, Aleksander, Yegor,

On Mon,  4 Nov 2019 09:48:44 -0300
unixmania at gmail.com wrote:

> If we have a cnfiguration like this
> 
>     BR2_PACKAGE_MODEM_MANAGER=y
>     # BR2_PACKAGE_MODEM_MANAGER_LIBMBIM is not set
>     BR2_PACKAGE_MODEM_MANAGER_LIBQMI=y
>     [...]
>     BR2_PACKAGE_LIBMBIM=y

I had a new look at this. We need a new iteration of this patch, since
the build issue doesn't exist anymore.

However, I would suggest to take a simpler approach:

 - Keep the BR2_PACKAGE_MODEM_MANAGER_LIBMBIM and
   BR2_PACKAGE_MODEM_MANAGER_LIBQMI options.

 - Change modem-manager.mk to test BR2_PACKAGE_LIBMBIM and
   BR2_PACKAGE_QMI instead of BR2_PACKAGE_MODEM_MANAGER_LIBMBIM and
   BR2_PACKAGE_MODEM_MANAGER_LIBQMI.

Also, as was pointed out during the discussion, it would be good to
change the network-manager package to not force the modem-manager
MBIM/QMI support when modem-manager support is enabled. I.e, remove the
following lines:

        select BR2_PACKAGE_MODEM_MANAGER_LIBMBIM
        select BR2_PACKAGE_MODEM_MANAGER_LIBQMI

from package/network-manager/Config.in

Could one of you have a look ?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2020-04-19 21:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-04 12:48 [Buildroot] [PATCH] package/modem-manager: use libqmi and libmbim if they are selected unixmania at gmail.com
2019-11-04 13:03 ` Aleksander Morgado
2019-11-04 13:27   ` Carlos Santos
2019-11-04 14:36     ` Aleksander Morgado
2019-11-04 17:30       ` Yegor Yefremov
2019-11-04 21:05 ` Thomas Petazzoni
2019-11-06 13:12   ` Arnout Vandecappelle
2019-11-06 20:45     ` Carlos Santos
2020-04-19 21:00 ` Thomas Petazzoni [this message]
2020-04-20  9:11   ` Aleksander Morgado
2020-04-20 11:54     ` Thomas Petazzoni
2020-05-05 12:10       ` Aleksander Morgado
2020-05-05 17:06   ` Yann E. MORIN
2020-05-06 13:09     ` Aleksander Morgado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200419230056.7df2d309@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox