From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/python-greenlet: disable on unsupported architectures
Date: Mon, 20 Apr 2020 07:54:30 +0200 [thread overview]
Message-ID: <20200420075430.23f2b737@windsurf.home> (raw)
In-Reply-To: <20200419233823.29410-1-james.hilliard1@gmail.com>
On Sun, 19 Apr 2020 17:38:23 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:
> diff --git a/package/python-greenlet/Config.in b/package/python-greenlet/Config.in
> index ef82375b0b..eae76ef6be 100644
> --- a/package/python-greenlet/Config.in
> +++ b/package/python-greenlet/Config.in
> @@ -1,5 +1,11 @@
> config BR2_PACKAGE_PYTHON_GREENLET
> bool "python-greenlet"
> + depends on !BR2_arceb
> + depends on !BR2_arcle
> + depends on !BR2_microblazebe
> + depends on !BR2_microblazeel
> + depends on !BR2_or1k
> + depends on !BR2_sh
We prefer to use a BR2_PACKAGE_foo_ARCH_SUPPORTS hidden boolean, and to
use positive logic (i.e enable the package for supported architectures,
not disable for unsupported one). For example, you had probably missed
nios2 or nds32 as unsupported architectures.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2020-04-20 5:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 23:38 [Buildroot] [PATCH 1/1] package/python-greenlet: disable on unsupported architectures James Hilliard
2020-04-20 5:54 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420075430.23f2b737@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox