From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1 2/6] package/qt5base: drop all legacy gcc requierements below 5.0
Date: Mon, 20 Apr 2020 20:35:33 +0200 [thread overview]
Message-ID: <20200420203533.399c1fd2@gmx.net> (raw)
In-Reply-To: <20200419150305.5a898e07@windsurf.home>
Hello Thomas,
On Sun, 19 Apr 2020 15:03:05 +0200, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> On Sun, 19 Apr 2020 00:59:02 +0200
> Peter Seiderer <ps.report@gmx.net> wrote:
>
> > As qt5 requires as minimum gcc 5.0 drop all legacy requierements below.
> >
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> > ---
> > package/qt5/qt5base/Config.in | 9 +--------
> > 1 file changed, 1 insertion(+), 8 deletions(-)
>
> I have not applied this one, and neither the remaining patches in the
> series. Indeed, we normally want to propagate "depends on" to all
> reverse dependencies, even if in practice it is already not possible to
> select a given option due to it being hidden by a "depends on" at a
> higher level.
>
> We believe that always duplicating improves consistency and helps
> avoiding mistakes. I agree that we are not 100% consistent on this
> throughout the tree, but the direction we want to go to is to replicate
> these "depends no", not get rid of them.
>
> I agree that this is a very 'opinionated' decision and I am myself a
> bit split between the two possibilities we have. But the overall
> consensus seems to be that we should have that duplication.
>
> So, I've marked PATCH 2/6 to 6/6 as Rejected.
Fine with me ;-), and thanks for the detailed explanation...
Regards,
Peter
>
> Thanks!
>
> Thomas
next prev parent reply other threads:[~2020-04-20 18:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-18 22:59 [Buildroot] [PATCH v1 1/6] package/qt5: bump minimum gcc requirement to 5.0 Peter Seiderer
2020-04-18 22:59 ` [Buildroot] [PATCH v1 2/6] package/qt5base: drop all legacy gcc requierements below 5.0 Peter Seiderer
2020-04-19 13:03 ` Thomas Petazzoni
2020-04-20 18:35 ` Peter Seiderer [this message]
2020-04-18 22:59 ` [Buildroot] [PATCH v1 3/6] package/qt5tools: " Peter Seiderer
2020-04-18 22:59 ` [Buildroot] [PATCH v1 4/6] package/qt5webengine: " Peter Seiderer
2020-04-18 22:59 ` [Buildroot] [PATCH v1 5/6] package/qt5webkit: " Peter Seiderer
2020-04-18 22:59 ` [Buildroot] [PATCH v1 6/6] package/qt-webkit-kiosk: " Peter Seiderer
2020-04-19 13:00 ` [Buildroot] [PATCH v1 1/6] package/qt5: bump minimum gcc requirement to 5.0 Thomas Petazzoni
2020-05-06 5:48 ` Peter Korsgaard
2020-05-06 6:44 ` Peter Seiderer
2020-05-06 7:37 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420203533.399c1fd2@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox