From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] packages/exim: enable parallel make
Date: Mon, 20 Apr 2020 23:08:41 +0200 [thread overview]
Message-ID: <20200420210841.GL5035@scaer> (raw)
In-Reply-To: <20200420163645.17803-1-luca@lucaceresoli.net>
Luca, All,
On 2020-04-20 18:36 +0200, Luca Ceresoli spake thusly:
> Parallel make used to be broken in exim, as reported in its docs. Now that
> line has disappeared from the docs, and parallel make is actually working.
>
> Tested with 'make exim-dirclean ; time make BR2_JLEVEL=999 exim': builds
> still succeed and the build time decreases from 34 to 11 seconds on my
> host.
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/exim/exim.mk | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/package/exim/exim.mk b/package/exim/exim.mk
> index 8d5b6e415b62..dc445c6d93c0 100644
> --- a/package/exim/exim.mk
> +++ b/package/exim/exim.mk
> @@ -120,16 +120,14 @@ endif
>
> # We need the host version of macro_predef during the build, before
> # building it we need to prepare the makefile.
> -# "The -j (parallel) flag must not be used with make"
> -# (http://www.exim.org/exim-html-current/doc/html/spec_html/ch04.html)
> define EXIM_BUILD_CMDS
> - $(TARGET_MAKE_ENV) build=br $(MAKE1) -C $(@D) makefile
> - $(HOST_MAKE_ENV) $(MAKE1) -C $(@D)/build-br macro_predef \
> + $(TARGET_MAKE_ENV) build=br $(MAKE) -C $(@D) makefile
> + $(HOST_MAKE_ENV) $(MAKE) -C $(@D)/build-br macro_predef \
> CC=$(HOSTCC) \
> LNCC=$(HOSTCC) \
> CFLAGS="-std=c99 $(HOST_CFLAGS)" \
> LFLAGS="-fPIC $(HOST_LDFLAGS)"
> - $(TARGET_MAKE_ENV) build=br $(MAKE1) -C $(@D) $(EXIM_STATIC_FLAGS) \
> + $(TARGET_MAKE_ENV) build=br $(MAKE) -C $(@D) $(EXIM_STATIC_FLAGS) \
> CFLAGS="-std=c99 $(TARGET_CFLAGS)"
> endef
>
> @@ -137,7 +135,7 @@ endef
> # something when installing...
> define EXIM_INSTALL_TARGET_CMDS
> DESTDIR=$(TARGET_DIR) INSTALL_ARG="-no_chown -no_symlink" build=br \
> - $(MAKE1) -C $(@D) $(EXIM_STATIC_FLAGS) \
> + $(MAKE) -C $(@D) $(EXIM_STATIC_FLAGS) \
> CFLAGS="-std=c99 $(TARGET_CFLAGS)" \
> install
> chmod u+s $(TARGET_DIR)/usr/sbin/exim
> --
> 2.26.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2020-04-20 21:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 16:36 [Buildroot] [PATCH] packages/exim: enable parallel make Luca Ceresoli
2020-04-20 19:03 ` Bernd Kuhls
2020-04-20 21:08 ` Yann E. MORIN [this message]
2020-05-06 6:00 ` Peter Korsgaard
2020-05-06 7:09 ` Luca Ceresoli
2020-05-06 7:39 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420210841.GL5035@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox