From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/libselinux: fix glibc build with old toolchains
Date: Mon, 20 Apr 2020 23:19:45 +0200 [thread overview]
Message-ID: <20200420211945.GN5035@scaer> (raw)
In-Reply-To: <20200420200058.1660444-1-fontaine.fabrice@gmail.com>
Fabrice, All,
On 2020-04-20 22:00 +0200, Fabrice Fontaine spake thusly:
> For an unknown reason, since bump to version 3.0.0, we got build failure
> due to -D_FILE_OFFSET_BITS==64:
>
> /home/naourr/work/instance-2/output-1/host/arm-buildroot-linux-gnueabi/sysroot/usr/include/fts.h:41:3: error: #error "<fts.h> cannot be used with -D_FILE_OFFSET_BITS==64"
> # error "<fts.h> cannot be used with -D_FILE_OFFSET_BITS==64"
> ^
>
> Update our workaround to also filter CPPFLAGS fix the issue and seems
> right as we're doing it for all the other affected packages
> (restorecond, elfutils ...)
>
> Fixes:
> - http://autobuild.buildroot.org/results/200fd0accf6a1926251243b05e600fbf591bb3a2
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks!
Regards,
Yann E. MORIN.
> ---
> package/libselinux/libselinux.mk | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/package/libselinux/libselinux.mk b/package/libselinux/libselinux.mk
> index b53146e30b..258065b79d 100644
> --- a/package/libselinux/libselinux.mk
> +++ b/package/libselinux/libselinux.mk
> @@ -45,12 +45,13 @@ define LIBSELINUX_BUILD_PYTHON_BINDINGS
> endef
> endif # python3
>
> -# Filter out D_FILE_OFFSET_BITS=64. This fixes errors caused by glibc
> -# 2.22. We set CFLAGS and LDFLAGS here because we want to win over the
> -# CFLAGS/LDFLAGS definitions passed by $(PKG_PYTHON_DISTUTILS_ENV)
> +# Filter out D_FILE_OFFSET_BITS=64. This fixes errors caused by glibc 2.22. We
> +# set CFLAGS, CPPFLAGS and LDFLAGS here because we want to win over the
> +# CFLAGS/CPPFLAGS/LDFLAGS definitions passed by $(PKG_PYTHON_DISTUTILS_ENV)
> # when the python binding is enabled.
> LIBSELINUX_MAKE_OPTS += \
> CFLAGS="$(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CFLAGS))" \
> + CPPFLAGS="$(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CPPFLAGS))" \
> LDFLAGS="$(TARGET_LDFLAGS) -lpcre -lpthread"
>
> define LIBSELINUX_BUILD_CMDS
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2020-04-20 21:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 20:00 [Buildroot] [PATCH 1/1] package/libselinux: fix glibc build with old toolchains Fabrice Fontaine
2020-04-20 21:14 ` Adam Duskett
2020-04-20 21:15 ` Adam Duskett
2020-04-20 21:19 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420211945.GN5035@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox