* [Buildroot] [PATCH 1/1] package/libselinux: fix glibc build with old toolchains
@ 2020-04-20 20:00 Fabrice Fontaine
2020-04-20 21:14 ` Adam Duskett
2020-04-20 21:19 ` Yann E. MORIN
0 siblings, 2 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2020-04-20 20:00 UTC (permalink / raw)
To: buildroot
For an unknown reason, since bump to version 3.0.0, we got build failure
due to -D_FILE_OFFSET_BITS==64:
/home/naourr/work/instance-2/output-1/host/arm-buildroot-linux-gnueabi/sysroot/usr/include/fts.h:41:3: error: #error "<fts.h> cannot be used with -D_FILE_OFFSET_BITS==64"
# error "<fts.h> cannot be used with -D_FILE_OFFSET_BITS==64"
^
Update our workaround to also filter CPPFLAGS fix the issue and seems
right as we're doing it for all the other affected packages
(restorecond, elfutils ...)
Fixes:
- http://autobuild.buildroot.org/results/200fd0accf6a1926251243b05e600fbf591bb3a2
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/libselinux/libselinux.mk | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/package/libselinux/libselinux.mk b/package/libselinux/libselinux.mk
index b53146e30b..258065b79d 100644
--- a/package/libselinux/libselinux.mk
+++ b/package/libselinux/libselinux.mk
@@ -45,12 +45,13 @@ define LIBSELINUX_BUILD_PYTHON_BINDINGS
endef
endif # python3
-# Filter out D_FILE_OFFSET_BITS=64. This fixes errors caused by glibc
-# 2.22. We set CFLAGS and LDFLAGS here because we want to win over the
-# CFLAGS/LDFLAGS definitions passed by $(PKG_PYTHON_DISTUTILS_ENV)
+# Filter out D_FILE_OFFSET_BITS=64. This fixes errors caused by glibc 2.22. We
+# set CFLAGS, CPPFLAGS and LDFLAGS here because we want to win over the
+# CFLAGS/CPPFLAGS/LDFLAGS definitions passed by $(PKG_PYTHON_DISTUTILS_ENV)
# when the python binding is enabled.
LIBSELINUX_MAKE_OPTS += \
CFLAGS="$(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CFLAGS))" \
+ CPPFLAGS="$(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CPPFLAGS))" \
LDFLAGS="$(TARGET_LDFLAGS) -lpcre -lpthread"
define LIBSELINUX_BUILD_CMDS
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/libselinux: fix glibc build with old toolchains
2020-04-20 20:00 [Buildroot] [PATCH 1/1] package/libselinux: fix glibc build with old toolchains Fabrice Fontaine
@ 2020-04-20 21:14 ` Adam Duskett
2020-04-20 21:15 ` Adam Duskett
2020-04-20 21:19 ` Yann E. MORIN
1 sibling, 1 reply; 4+ messages in thread
From: Adam Duskett @ 2020-04-20 21:14 UTC (permalink / raw)
To: buildroot
All;
Tested-by Adam Duskett <Aduskett@gmail.com>
On Mon, Apr 20, 2020 at 12:59 PM Fabrice Fontaine
<fontaine.fabrice@gmail.com> wrote:
>
> For an unknown reason, since bump to version 3.0.0, we got build failure
> due to -D_FILE_OFFSET_BITS==64:
>
> /home/naourr/work/instance-2/output-1/host/arm-buildroot-linux-gnueabi/sysroot/usr/include/fts.h:41:3: error: #error "<fts.h> cannot be used with -D_FILE_OFFSET_BITS==64"
> # error "<fts.h> cannot be used with -D_FILE_OFFSET_BITS==64"
> ^
>
> Update our workaround to also filter CPPFLAGS fix the issue and seems
> right as we're doing it for all the other affected packages
> (restorecond, elfutils ...)
>
> Fixes:
> - http://autobuild.buildroot.org/results/200fd0accf6a1926251243b05e600fbf591bb3a2
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/libselinux/libselinux.mk | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/package/libselinux/libselinux.mk b/package/libselinux/libselinux.mk
> index b53146e30b..258065b79d 100644
> --- a/package/libselinux/libselinux.mk
> +++ b/package/libselinux/libselinux.mk
> @@ -45,12 +45,13 @@ define LIBSELINUX_BUILD_PYTHON_BINDINGS
> endef
> endif # python3
>
> -# Filter out D_FILE_OFFSET_BITS=64. This fixes errors caused by glibc
> -# 2.22. We set CFLAGS and LDFLAGS here because we want to win over the
> -# CFLAGS/LDFLAGS definitions passed by $(PKG_PYTHON_DISTUTILS_ENV)
> +# Filter out D_FILE_OFFSET_BITS=64. This fixes errors caused by glibc 2.22. We
> +# set CFLAGS, CPPFLAGS and LDFLAGS here because we want to win over the
> +# CFLAGS/CPPFLAGS/LDFLAGS definitions passed by $(PKG_PYTHON_DISTUTILS_ENV)
> # when the python binding is enabled.
> LIBSELINUX_MAKE_OPTS += \
> CFLAGS="$(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CFLAGS))" \
> + CPPFLAGS="$(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CPPFLAGS))" \
> LDFLAGS="$(TARGET_LDFLAGS) -lpcre -lpthread"
>
> define LIBSELINUX_BUILD_CMDS
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/libselinux: fix glibc build with old toolchains
2020-04-20 21:14 ` Adam Duskett
@ 2020-04-20 21:15 ` Adam Duskett
0 siblings, 0 replies; 4+ messages in thread
From: Adam Duskett @ 2020-04-20 21:15 UTC (permalink / raw)
To: buildroot
All;
Tested-by: Adam Duskett <Aduskett@gmail.com>
On Mon, Apr 20, 2020 at 2:14 PM Adam Duskett <aduskett@gmail.com> wrote:
>
> All;
>
> Tested-by Adam Duskett <Aduskett@gmail.com>
>
> On Mon, Apr 20, 2020 at 12:59 PM Fabrice Fontaine
> <fontaine.fabrice@gmail.com> wrote:
> >
> > For an unknown reason, since bump to version 3.0.0, we got build failure
> > due to -D_FILE_OFFSET_BITS==64:
> >
> > /home/naourr/work/instance-2/output-1/host/arm-buildroot-linux-gnueabi/sysroot/usr/include/fts.h:41:3: error: #error "<fts.h> cannot be used with -D_FILE_OFFSET_BITS==64"
> > # error "<fts.h> cannot be used with -D_FILE_OFFSET_BITS==64"
> > ^
> >
> > Update our workaround to also filter CPPFLAGS fix the issue and seems
> > right as we're doing it for all the other affected packages
> > (restorecond, elfutils ...)
> >
> > Fixes:
> > - http://autobuild.buildroot.org/results/200fd0accf6a1926251243b05e600fbf591bb3a2
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> > package/libselinux/libselinux.mk | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/package/libselinux/libselinux.mk b/package/libselinux/libselinux.mk
> > index b53146e30b..258065b79d 100644
> > --- a/package/libselinux/libselinux.mk
> > +++ b/package/libselinux/libselinux.mk
> > @@ -45,12 +45,13 @@ define LIBSELINUX_BUILD_PYTHON_BINDINGS
> > endef
> > endif # python3
> >
> > -# Filter out D_FILE_OFFSET_BITS=64. This fixes errors caused by glibc
> > -# 2.22. We set CFLAGS and LDFLAGS here because we want to win over the
> > -# CFLAGS/LDFLAGS definitions passed by $(PKG_PYTHON_DISTUTILS_ENV)
> > +# Filter out D_FILE_OFFSET_BITS=64. This fixes errors caused by glibc 2.22. We
> > +# set CFLAGS, CPPFLAGS and LDFLAGS here because we want to win over the
> > +# CFLAGS/CPPFLAGS/LDFLAGS definitions passed by $(PKG_PYTHON_DISTUTILS_ENV)
> > # when the python binding is enabled.
> > LIBSELINUX_MAKE_OPTS += \
> > CFLAGS="$(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CFLAGS))" \
> > + CPPFLAGS="$(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CPPFLAGS))" \
> > LDFLAGS="$(TARGET_LDFLAGS) -lpcre -lpthread"
> >
> > define LIBSELINUX_BUILD_CMDS
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/libselinux: fix glibc build with old toolchains
2020-04-20 20:00 [Buildroot] [PATCH 1/1] package/libselinux: fix glibc build with old toolchains Fabrice Fontaine
2020-04-20 21:14 ` Adam Duskett
@ 2020-04-20 21:19 ` Yann E. MORIN
1 sibling, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2020-04-20 21:19 UTC (permalink / raw)
To: buildroot
Fabrice, All,
On 2020-04-20 22:00 +0200, Fabrice Fontaine spake thusly:
> For an unknown reason, since bump to version 3.0.0, we got build failure
> due to -D_FILE_OFFSET_BITS==64:
>
> /home/naourr/work/instance-2/output-1/host/arm-buildroot-linux-gnueabi/sysroot/usr/include/fts.h:41:3: error: #error "<fts.h> cannot be used with -D_FILE_OFFSET_BITS==64"
> # error "<fts.h> cannot be used with -D_FILE_OFFSET_BITS==64"
> ^
>
> Update our workaround to also filter CPPFLAGS fix the issue and seems
> right as we're doing it for all the other affected packages
> (restorecond, elfutils ...)
>
> Fixes:
> - http://autobuild.buildroot.org/results/200fd0accf6a1926251243b05e600fbf591bb3a2
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks!
Regards,
Yann E. MORIN.
> ---
> package/libselinux/libselinux.mk | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/package/libselinux/libselinux.mk b/package/libselinux/libselinux.mk
> index b53146e30b..258065b79d 100644
> --- a/package/libselinux/libselinux.mk
> +++ b/package/libselinux/libselinux.mk
> @@ -45,12 +45,13 @@ define LIBSELINUX_BUILD_PYTHON_BINDINGS
> endef
> endif # python3
>
> -# Filter out D_FILE_OFFSET_BITS=64. This fixes errors caused by glibc
> -# 2.22. We set CFLAGS and LDFLAGS here because we want to win over the
> -# CFLAGS/LDFLAGS definitions passed by $(PKG_PYTHON_DISTUTILS_ENV)
> +# Filter out D_FILE_OFFSET_BITS=64. This fixes errors caused by glibc 2.22. We
> +# set CFLAGS, CPPFLAGS and LDFLAGS here because we want to win over the
> +# CFLAGS/CPPFLAGS/LDFLAGS definitions passed by $(PKG_PYTHON_DISTUTILS_ENV)
> # when the python binding is enabled.
> LIBSELINUX_MAKE_OPTS += \
> CFLAGS="$(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CFLAGS))" \
> + CPPFLAGS="$(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CPPFLAGS))" \
> LDFLAGS="$(TARGET_LDFLAGS) -lpcre -lpthread"
>
> define LIBSELINUX_BUILD_CMDS
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-20 21:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-20 20:00 [Buildroot] [PATCH 1/1] package/libselinux: fix glibc build with old toolchains Fabrice Fontaine
2020-04-20 21:14 ` Adam Duskett
2020-04-20 21:15 ` Adam Duskett
2020-04-20 21:19 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox