public inbox for buildroot@busybox.net
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/linux-tools: selftests: add numactl dependency for net tests
Date: Tue, 21 Apr 2020 16:55:10 +0200	[thread overview]
Message-ID: <20200421165510.0616fc36@windsurf.home> (raw)
In-Reply-To: <20200421175140.n5l3vn7rh642widp@vkochan-ThinkPad-T470p>

Hello,

On Tue, 21 Apr 2020 20:51:40 +0300
Vadim Kochan <vadim4j@gmail.com> wrote:

> > So, I think we should:
> > 
> >  - Pass FORCE_TARGETS=1 during the build so that the build aborts if a
> >    required dependency is not found.
> > 
> >  - Switch to using more optional dependencies, and disable the TARGETS
> >    that we cannot build by passing the appropriate SKIP_TARGETS value
> >    to the Makefile.
> > 
> > Could you work on this ? We probably need to make libcap-ng optional,
> > but also popt. The other options that are selected by
> > BR2_PACKAGE_LINUX_TOOLS_SELFTESTS might also need to be revisited.
> > 
> > An alternative is to just say that we don't care about making all of
> > that optional, and simply unconditionally enable all the dependencies
> > that selftests need, to build everything. Easier, but that's not the
> > normal Buildroot design principle.
> > 
> > Best regards,
> > 
> > Thomas  
> 
> Yes, I understand your point. I think it would be useful to add config
> options per each selftests subsystem to easy turn it on.

I don't know if we really want to add one sub-option for each selftest
subsystem, that would be quite a lot.

However, we should properly enable/disable selftest subsystems
depending on the availability of the necessary dependencies. For
example, if numactl is enabled, then we enable the network-related
selftests, otherwise we disable them.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2020-04-21 14:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-25 16:42 [Buildroot] [PATCH] package/linux-tools: selftests: add numactl dependency for net tests Vadym Kochan
2020-04-11 13:26 ` Thomas Petazzoni
2020-04-21 17:51   ` Vadim Kochan
2020-04-21 14:55     ` Thomas Petazzoni [this message]
2020-04-22 11:23       ` Vadim Kochan
2020-04-22  8:24         ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200421165510.0616fc36@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox