* [Buildroot] [PATCH v2,1/1] package/selinux-python: fix dependency
@ 2020-04-21 14:53 Fabrice Fontaine
2020-04-21 15:07 ` [Buildroot] [PATCH v2, 1/1] " Thomas Petazzoni
2020-04-21 17:02 ` Yann E. MORIN
0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2020-04-21 14:53 UTC (permalink / raw)
To: buildroot
Commit 791292c48d5165515ca08f35d8cbc1ef78d3ed95 forgot to add
!BR2_PACKAGE_PYTHON dependency, without it the following error will be
raised if the user selects BR2_PACKAGE_PYTHON and python-selinux:
WARNING: unmet direct dependencies detected for BR2_PACKAGE_PYTHON3
Depends on [n]: !BR2_PACKAGE_PYTHON [=y] && BR2_USE_WCHAR [=y] && BR2_USE_MMU [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] && !BR2_STATIC_LIBS [=n]
Selected by [y]:
- BR2_PACKAGE_SELINUX_PYTHON [=y] && BR2_USE_MMU [=y] && BR2_USE_WCHAR [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] && !BR2_STATIC_LIBS [=n]
Fixes:
- No autobuilder failures yet
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
Changes v1 -> v2 (after review of Thomas Petazzoni):
- Fix commit message, keep select and add a !BR2_PACKAGE_PYTHON
dependency
package/selinux-python/Config.in | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/selinux-python/Config.in b/package/selinux-python/Config.in
index 1a610b29f0..862a63095a 100644
--- a/package/selinux-python/Config.in
+++ b/package/selinux-python/Config.in
@@ -1,5 +1,6 @@
config BR2_PACKAGE_SELINUX_PYTHON
bool "selinux-python"
+ depends on !BR2_PACKAGE_PYTHON
depends on BR2_USE_MMU
depends on BR2_USE_WCHAR
depends on BR2_TOOLCHAIN_HAS_THREADS
@@ -37,6 +38,9 @@ config BR2_PACKAGE_SELINUX_PYTHON_SEPOLGEN
endif
+comment "selinux-python needs python3"
+ depends on BR2_PACKAGE_PYTHON
+
comment "selinux-python packages needs a toolchain w/ wchar, threads, dynamic library"
depends on BR2_USE_MMU
depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v2, 1/1] package/selinux-python: fix dependency
2020-04-21 14:53 [Buildroot] [PATCH v2,1/1] package/selinux-python: fix dependency Fabrice Fontaine
@ 2020-04-21 15:07 ` Thomas Petazzoni
2020-04-21 17:02 ` Yann E. MORIN
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2020-04-21 15:07 UTC (permalink / raw)
To: buildroot
On Tue, 21 Apr 2020 16:53:15 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Commit 791292c48d5165515ca08f35d8cbc1ef78d3ed95 forgot to add
> !BR2_PACKAGE_PYTHON dependency, without it the following error will be
> raised if the user selects BR2_PACKAGE_PYTHON and python-selinux:
>
> WARNING: unmet direct dependencies detected for BR2_PACKAGE_PYTHON3
> Depends on [n]: !BR2_PACKAGE_PYTHON [=y] && BR2_USE_WCHAR [=y] && BR2_USE_MMU [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] && !BR2_STATIC_LIBS [=n]
> Selected by [y]:
> - BR2_PACKAGE_SELINUX_PYTHON [=y] && BR2_USE_MMU [=y] && BR2_USE_WCHAR [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] && !BR2_STATIC_LIBS [=n]
Aah, yes. Indeed. Now it makes complete sense. And thank you for fixing
this, I indeed completely overlooked that when changing the "select
BR2_PACKAGE_PYTHON3".
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v2, 1/1] package/selinux-python: fix dependency
2020-04-21 14:53 [Buildroot] [PATCH v2,1/1] package/selinux-python: fix dependency Fabrice Fontaine
2020-04-21 15:07 ` [Buildroot] [PATCH v2, 1/1] " Thomas Petazzoni
@ 2020-04-21 17:02 ` Yann E. MORIN
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2020-04-21 17:02 UTC (permalink / raw)
To: buildroot
Fabrice, All,
On 2020-04-21 16:53 +0200, Fabrice Fontaine spake thusly:
> Commit 791292c48d5165515ca08f35d8cbc1ef78d3ed95 forgot to add
> !BR2_PACKAGE_PYTHON dependency, without it the following error will be
> raised if the user selects BR2_PACKAGE_PYTHON and python-selinux:
>
> WARNING: unmet direct dependencies detected for BR2_PACKAGE_PYTHON3
> Depends on [n]: !BR2_PACKAGE_PYTHON [=y] && BR2_USE_WCHAR [=y] && BR2_USE_MMU [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] && !BR2_STATIC_LIBS [=n]
> Selected by [y]:
> - BR2_PACKAGE_SELINUX_PYTHON [=y] && BR2_USE_MMU [=y] && BR2_USE_WCHAR [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] && !BR2_STATIC_LIBS [=n]
>
> Fixes:
> - No autobuilder failures yet
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Thomas Petazzoni):
> - Fix commit message, keep select and add a !BR2_PACKAGE_PYTHON
> dependency
>
> package/selinux-python/Config.in | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/package/selinux-python/Config.in b/package/selinux-python/Config.in
> index 1a610b29f0..862a63095a 100644
> --- a/package/selinux-python/Config.in
> +++ b/package/selinux-python/Config.in
> @@ -1,5 +1,6 @@
> config BR2_PACKAGE_SELINUX_PYTHON
> bool "selinux-python"
> + depends on !BR2_PACKAGE_PYTHON
> depends on BR2_USE_MMU
> depends on BR2_USE_WCHAR
> depends on BR2_TOOLCHAIN_HAS_THREADS
> @@ -37,6 +38,9 @@ config BR2_PACKAGE_SELINUX_PYTHON_SEPOLGEN
>
> endif
>
> +comment "selinux-python needs python3"
> + depends on BR2_PACKAGE_PYTHON
I've added a dependency on MMU, as there is nothing that can be done
about that. Applied to master, thanks.
Regards,
Yann E. MORIN.
> comment "selinux-python packages needs a toolchain w/ wchar, threads, dynamic library"
> depends on BR2_USE_MMU
> depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-21 17:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-21 14:53 [Buildroot] [PATCH v2,1/1] package/selinux-python: fix dependency Fabrice Fontaine
2020-04-21 15:07 ` [Buildroot] [PATCH v2, 1/1] " Thomas Petazzoni
2020-04-21 17:02 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox