public inbox for buildroot@busybox.net
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/uacme: bump version to 1.2.2
Date: Tue, 21 Apr 2020 22:37:28 +0200	[thread overview]
Message-ID: <20200421223728.6f56ef29@windsurf.home> (raw)
In-Reply-To: <20200418212617.rmizagunxkkzwwom@einstein.dilieto.eu>

Hello Nicola,

On Sat, 18 Apr 2020 23:26:17 +0200
Nicola Di Lieto <nicola.dilieto@gmail.com> wrote:

> This version includes a new binary named "ualpn", a proxying
> ACMEv2 tls-alpn-01 responder.
> 
> Signed-off-by: Nicola Di Lieto <nicola.dilieto@gmail.com>

I've applied, with some changes. See below.

> +if BR2_PACKAGE_UACME
> +
> +config BR2_PACKAGE_UACME_UALPN
> +	bool "enable ualpn"
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	select BR2_PACKAGE_LIBEV
> +	default y

We typically don't enable by default sub-options / optional features,
so I've dropped this "default y". It was also generating a "make
check-package" warning due to the ordering of statements.

> -UACME_VERSION = 1.0.22
> +UACME_VERSION = 1.2.2
>  # Released versions are on branch upstream/latest, tagged as
>  # upstream/X.Y.Z Do not use vX.Y.Z tags from master, as they do not
>  # include .tarball-version
> @@ -26,4 +26,10 @@ UACME_CONF_OPTS += --with-openssl
>  UACME_DEPENDENCIES += openssl
>  endif
>  
> +ifeq ($(BR2_PACKAGE_UACME_UALPN),y)
> +UACME_DEPENDENCIES += libev

I've added a:

UACME_CONF_OPTS += --with-ualpn

as we like to be explicit when enabling and disabling features.l

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2020-04-21 20:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-18 21:26 [Buildroot] [PATCH v2] package/uacme: bump version to 1.2.2 Nicola Di Lieto
2020-04-21 20:37 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200421223728.6f56ef29@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox