From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] configs/qemu_riscv{32, 64}_virt_defconfig: Remove BR2_TARGET_GENERIC_GETTY_PORT
Date: Tue, 21 Apr 2020 23:19:32 +0200 [thread overview]
Message-ID: <20200421231932.74abbc93@windsurf.home> (raw)
In-Reply-To: <1583583630-25647-1-git-send-email-bmeng.cn@gmail.com>
On Sat, 7 Mar 2020 04:20:30 -0800
Bin Meng <bmeng.cn@gmail.com> wrote:
> Currently BR2_TARGET_GENERIC_GETTY_PORT is set to ttyS0 in both
> qemu_riscv32_virt and qemu_riscv64_virt defconfig files. This
> limits usecases when the same one rootfs could be used on QEMU
> 'sifive_u' machine and SiFive HiFive Unleashed board.
>
> Remove it so that the default boot console can be used.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
Applied to master with a reworked commit log. Indeed, these options are
not really needed, but the idea that these defconfigs should be used on
other HW platforms than the Qemu emulation is not a good idea, as
pointed out by other reviewers.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2020-04-21 21:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-07 12:20 [Buildroot] [PATCH] configs/qemu_riscv{32, 64}_virt_defconfig: Remove BR2_TARGET_GENERIC_GETTY_PORT Bin Meng
2020-03-12 1:50 ` Bin Meng
2020-03-17 1:49 ` Bin Meng
2020-03-22 15:52 ` Romain Naour
2020-03-22 16:01 ` Yann E. MORIN
2020-03-22 16:13 ` Yann E. MORIN
2020-03-23 5:38 ` Bin Meng
2020-04-21 21:19 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421231932.74abbc93@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox