From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/matio: new package
Date: Fri, 24 Apr 2020 14:05:45 +0200 [thread overview]
Message-ID: <20200424120545.GK5035@scaer> (raw)
In-Reply-To: <20200424085624.23908-1-gwenj@trabucayre.com>
Gwenhael, All,
On 2020-04-24 10:56 +0200, Gwenhael Goavec-Merou spake thusly:
> From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
>
> matio is an C library for reading and writing MATLAB MAT files.
>
> Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
> ---
[--SNIP--]
> diff --git a/package/matio/Config.in b/package/matio/Config.in
> new file mode 100644
> index 0000000000..b6c4223e44
> --- /dev/null
> +++ b/package/matio/Config.in
> @@ -0,0 +1,15 @@
> +config BR2_PACKAGE_MATIO
> + bool "matio"
> + select BR2_PACKAGE_ZLIB
> + help
> + matio is an C library for reading and writing MATLAB MAT
> + files.
> +
> + https://sourceforge.net/projects/matio
> +
> +if BR2_PACKAGE_MATIO
> +
> +config BR2_PACKAGE_MATIO_SPARSE
> + bool "sparse support"
Why do we need this top be optional? Does it increase the size
considerably?
Im intrigued, because...
[--SNIP--]
> diff --git a/package/matio/matio.mk b/package/matio/matio.mk
> new file mode 100644
> index 0000000000..2ac46f10ad
> --- /dev/null
> +++ b/package/matio/matio.mk
> @@ -0,0 +1,25 @@
> +################################################################################
> +#
> +# matio
> +#
> +################################################################################
> +
> +MATIO_VERSION = 1.5.17
> +MATIO_SITE = http://downloads.sourceforge.net/project/matio/matio/$(MATIO_VERSION)
> +MATIO_LICENSE = BSD-2-Clause
> +MATIO_LICENSE_FILES = COPYING
> +MATIO_DEPENDENCIES = zlib
> +MATIO_INSTALL_STAGING = YES
> +
> +# va_copy()
> +MATIO_CONF_ENV = ac_cv_va_copy=yes
> +
> +MATIO_CONF_OPTS = --enable-mat73=no
... here you explicitly disable a feature.
> +ifeq ($(BR2_PACKAGE_MATIO_SPARSE),y)
> +MATIO_CONF_OPTS += --enable-extended-sparse=yes
> +else
> +MATIO_CONF_OPTS += --enable-extended-sparse=no
Usually, we use: --enable-extended-sparse and --disable-extended-sparse=yes
Regards,
Yann E. MORIN.
> +endif
> +
> +$(eval $(autotools-package))
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2020-04-24 12:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 8:56 [Buildroot] [PATCH v2] package/matio: new package Gwenhael Goavec-Merou
2020-04-24 12:05 ` Yann E. MORIN [this message]
2020-04-24 12:47 ` Gwenhael Goavec-Merou
2020-04-25 9:50 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424120545.GK5035@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox