Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/python-autobahn: bump to version 20.4.3
Date: Sat, 25 Apr 2020 15:30:40 +0200	[thread overview]
Message-ID: <20200425153040.297e371c@windsurf.home> (raw)
In-Reply-To: <20200424224752.63673-1-james.hilliard1@gmail.com>

On Fri, 24 Apr 2020 16:47:52 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> Autobahn recently added a feature called xbr which we don't support,
> let's remove this before building autobahn.

Why don't we support it? Can it be made optional in a way that is
acceptable upstream?

> +define PYTHON_AUTOBAHN_REMOVE_XBR
> +	rm -rf $(@D)/autobahn/xbr
> +	rm -f $(@D)/autobahn/asyncio/xbr.py
> +	rm -f $(@D)/autobahn/twisted/xbr.py
> +	sed -i -e "/'autobahn\.xbr',/d" $(@D)/setup.py
> +	sed -i -e "/'xbr': \['\.\/xbr\/contracts\/\*\.json'\],/d" $(@D)/setup.py
> +	sed -i -e '/"xbrnetwork = autobahn\.xbr\._cli:_main",/d' $(@D)/setup.py
> +	sed -i -e '/xbr/d' $(@D)/MANIFEST.in
> +endef

Urgh, we want a patch, not tweaks like that. I guess perhaps the patch
doesn't need to remove the actual source files, just remove the
handling in setup.py.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2020-04-25 13:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-24 22:47 [Buildroot] [PATCH 1/1] package/python-autobahn: bump to version 20.4.3 James Hilliard
2020-04-25 13:30 ` Thomas Petazzoni [this message]
2020-04-25 19:31   ` James Hilliard
2020-04-25 19:53     ` Thomas Petazzoni
2020-04-25 19:55       ` James Hilliard
2020-04-25 20:09         ` Thomas Petazzoni
2020-04-25 21:07           ` James Hilliard
2020-04-25 21:10             ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200425153040.297e371c@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox