[Buildroot] [PATCH 1/1] package/syrepo: fix SysV init script

Thomas Petazzoni
2020-04-25T14:22:21Z

Hello Heiko,

Minor nit: typo in commit title: syrepo -> sysrepo. More questions below.

On Mon, 20 Apr 2020 11:57:38 +0200
Heiko Thiery <heiko.thiery@gmail.com> wrote:

> The sysrepo-plugind does not support to be controlled via the PID by the
> start-stop-daemon. This is because sysrepo-plugind does a fork.
> Thus the daemon is running with another PID known by start-stop-daemon.

"known" by start-stop-daemon, or "not known" ?

Also, it is not very clear. Indeed, in the "start" step, you're not
asking start-stop-daemon to create a PID file using the -m option. So
you're relying on the daemon to create one. Is this PID file incorrect
? Normally, when it is created by the daemon itself, even if the daemon
forks, it should be fine.

Otherwise, can you ask the daemon not to fork, and let
start-stop-daemon take care of this ?

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering