[Buildroot] [PATCH 1/1] package/syrepo: fix SysV init script

Thomas Petazzoni
2020-04-25T20:07:58Z

On Sat, 25 Apr 2020 21:58:56 +0200
Heiko Thiery <heiko.thiery@gmail.com> wrote:

> No it doesn't. The confusion is due to my bad commit message ;-/ I try
> to explain it better.
>
> The current script is not able to stop the daemon.
>
> Options to fix the problem:
>
> A) By adding the "-m -p $PIDFILE" option the pid file will be created
> but it will not contain the correct PID used by the daemon. This is
> obviously because the daemon forks.
> B) By not starting the daemon in background (sysrepo-plugind -d) and
> let do it by start-stop-daemon with "-b" option the log messages of
> the daemon will not longer ends in the syslog but to stderr.
> C) start the daemon without a pidfile and stop the daemon with the "-x" option.
>
> I think the best option is C. This is what the patch does.

Absolutely :-) I'll update the commit message with this explanation
when applying.

Thanks!

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering