From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] toolchain/toolchain-external: install ldd on the target
Date: Mon, 27 Apr 2020 22:55:37 +0200 [thread overview]
Message-ID: <20200427205537.GD11346@scaer> (raw)
In-Reply-To: <20200422153442.31989-1-sebastien.szymanski@armadeus.com>
S?bastien, All,
On 2020-04-22 17:34 +0200, S?bastien Szymanski spake thusly:
> From: Julien Boibessot <julien.boibessot@armadeus.com>
>
> From: Julien Boibessot <julien.boibessot@armadeus.com>
>
> It could be usefull to have ldd on the target so install it.
>
> Signed-off-by: Julien Boibessot <julien.boibessot@armadeus.com>
> [S?bastien: add commit message]
> Signed-off-by: S?bastien Szymanski <sebastien.szymanski@armadeus.com>
I was not too fond of it, but it looks like we do install it for an
internal glibc-based toolchain, so meh...
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> toolchain/toolchain-external/pkg-toolchain-external.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/toolchain/toolchain-external/pkg-toolchain-external.mk b/toolchain/toolchain-external/pkg-toolchain-external.mk
> index 8667d7ddf6..6d91cb5d1e 100644
> --- a/toolchain/toolchain-external/pkg-toolchain-external.mk
> +++ b/toolchain/toolchain-external/pkg-toolchain-external.mk
> @@ -499,6 +499,12 @@ define TOOLCHAIN_EXTERNAL_FIXUP_UCLIBCNG_LDSO
> fi
> endef
>
> +define TOOLCHAIN_EXTERNAL_INSTALL_TARGET_LDD
> + $(Q)if test -f $(STAGING_DIR)/usr/bin/ldd ; then \
> + $(INSTALL) -D $(STAGING_DIR)/usr/bin/ldd $(TARGET_DIR)/usr/bin/ldd ; \
> + $(SED) 's:.*/bin/bash:#!/bin/sh:' $(TARGET_DIR)/usr/bin/ldd ; \
> + fi
> +endef
>
> ################################################################################
> # inner-toolchain-external-package -- defines the generic installation rules
> @@ -593,6 +599,7 @@ define $(2)_INSTALL_TARGET_CMDS
> $$(TOOLCHAIN_EXTERNAL_INSTALL_TARGET_LIBS)
> $$(TOOLCHAIN_EXTERNAL_INSTALL_TARGET_GDBSERVER)
> $$(TOOLCHAIN_EXTERNAL_FIXUP_UCLIBCNG_LDSO)
> + $$(TOOLCHAIN_EXTERNAL_INSTALL_TARGET_LDD)
> endef
>
> # Call the generic package infrastructure to generate the necessary
> --
> 2.25.3
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2020-04-27 20:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 15:34 [Buildroot] [PATCH 1/1] toolchain/toolchain-external: install ldd on the target Sébastien Szymanski
2020-04-24 12:02 ` Yann E. MORIN
2020-04-24 12:16 ` Thomas Petazzoni
2020-04-27 20:55 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427205537.GD11346@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox