From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] boot/uboot: add option to define custom dependencies
Date: Mon, 27 Apr 2020 21:08:49 +0200 [thread overview]
Message-ID: <20200427210849.436f0a53@windsurf.home> (raw)
In-Reply-To: <794007695.ejsOJfsjEF@diego>
On Mon, 27 Apr 2020 20:19:45 +0200
Heiko Stuebner <heiko.stuebner@theobroma-systems.com> wrote:
> Am Montag, 27. April 2020, 18:59:51 CEST schrieb Arnout Vandecappelle:
> > On 27/04/2020 17:41, Thomas Petazzoni wrote:
> > > Thanks. Should I nevertheless introduce the PYLIBFDT_PYTHON3 and
> > > PYELFTOOLS_PYTHON3 options, in addition to this ? Or do we for these
> > > new use cases favor using only the CUSTOM_DEPENDENCIES solution ?
> >
> > Given how controversial this new option is, I guess it's better to add the
> > -python3 options.
>
> personally I imagined CUSTOM_DEPENDENCIES to _not_ be preferred
> over standard options.
Indeed, they are not necessarily mutually exclusive.
> I.e. things like BR2_TARGET_UBOOT_NEEDS_ATF_BL31 come with their
> own special handling for example for including the bl31 binary into the
> build.
NEEDS_ATF_BL31 indeed does more than adding dependencies. But:
ifeq ($(BR2_TARGET_UBOOT_NEEDS_DTC),y)
UBOOT_DEPENDENCIES += host-dtc
endif
ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYLIBFDT),y)
UBOOT_DEPENDENCIES += host-python host-swig
endif
ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYELFTOOLS),y)
UBOOT_DEPENDENCIES += host-python-pyelftools
endif
ifeq ($(BR2_TARGET_UBOOT_NEEDS_OPENSSL),y)
UBOOT_DEPENDENCIES += host-openssl
endif
ifeq ($(BR2_TARGET_UBOOT_NEEDS_LZOP),y)
UBOOT_DEPENDENCIES += host-lzop
endif
is really all about adding dependencies, and we need two more.
But OK, I'll cook a patch to support the Python 3.x situation.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-04-27 19:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-25 0:06 [Buildroot] [PATCH] boot/uboot: add option to define custom dependencies Heiko Stuebner
2020-04-25 13:38 ` Thomas Petazzoni
2020-04-25 21:13 ` Yann E. MORIN
2020-04-25 21:22 ` Thomas Petazzoni
2020-04-25 21:31 ` Heiko Stübner
2020-04-25 21:45 ` Yann E. MORIN
2020-04-27 8:31 ` Arnout Vandecappelle
2020-04-27 15:41 ` Thomas Petazzoni
2020-04-27 16:59 ` Arnout Vandecappelle
[not found] ` <794007695.ejsOJfsjEF@diego>
2020-04-27 19:08 ` Thomas Petazzoni [this message]
2022-01-08 19:40 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427210849.436f0a53@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox