From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/apparmor: fix compilation with libintl
Date: Mon, 27 Apr 2020 23:06:49 +0200 [thread overview]
Message-ID: <20200427230649.5dec909e@windsurf.home> (raw)
In-Reply-To: <20200425140356.6448-1-angelo@amarulasolutions.com>
On Sat, 25 Apr 2020 16:03:56 +0200
Angelo Compagnucci <angelo.compagnucci@gmail.com> wrote:
> +ifeq ($(BR2_PACKAGE_GETTEXT_PROVIDES_LIBINTL),y)
> +APPARMOR_MAKE_OPTS += WITH_LIBINTL=1
I've added:
APPARMOR_DEPENDENCIES += gettext
here, otherwise, gettext is not guaranteed to be built before.
It is not strictly necessary, because the issue only occurs when the
libintl.h from gettext has replaced the one from the C library. So the
issue only appears when gettext has been compiled/installed before
apparmor.
But still, if BR2_PACKAGE_GETTEXT_PROVIDES_LIBINTL=y, it means that
gettext will be built, so we'd rather depend on it so that we have
gettext support in apparmor.
Applied with this change. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2020-04-27 21:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-25 14:03 [Buildroot] [PATCH v2] package/apparmor: fix compilation with libintl Angelo Compagnucci
2020-04-27 21:06 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427230649.5dec909e@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox