From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/pkg-meson.mk: set correct pkgconfig for native dependencies
Date: Tue, 28 Apr 2020 09:10:22 +0200 [thread overview]
Message-ID: <20200428091022.4c613e80@windsurf.home> (raw)
In-Reply-To: <d96ae071-26fa-25a4-a508-d52d82daafeb@mind.be>
On Tue, 28 Apr 2020 08:50:43 +0200
Arnout Vandecappelle <arnout@mind.be> wrote:
> On 28/04/2020 07:22, Thomas Petazzoni wrote:
> > +++ b/package/pkg-meson.mk
> > @@ -87,6 +87,7 @@ define $(2)_CONFIGURE_CMDS
> > --default-library=$(if $(BR2_STATIC_LIBS),static,shared) \
> > --buildtype=$(if $(BR2_ENABLE_DEBUG),debug,release) \
> > --cross-file=$$($$(PKG)_SRCDIR)/build/cross-compilation.conf \
> > + -Dbuild.pkg_config_path=$$(HOST_DIR)/lib/pkgconfig \
>
> This can't be right. Here you're setting the pkg_config_path to the one for
> native build. It may work in the specific case of wayland-scanner where you
> actually want the native one, but it will break anything that requires the cross
> package config.
Isn't the "build." scoping of that property going to make it apply only
for the native parts of the build ?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-04-28 7:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 4:06 [Buildroot] [PATCH 1/1] package/pkg-meson.mk: set correct pkgconfig for native dependencies James Hilliard
2020-04-28 5:22 ` Thomas Petazzoni
2020-04-28 5:28 ` James Hilliard
2020-04-28 5:32 ` Thomas Petazzoni
2020-04-28 5:39 ` James Hilliard
2020-04-28 6:48 ` Arnout Vandecappelle
2020-04-28 6:50 ` Arnout Vandecappelle
2020-04-28 6:55 ` James Hilliard
2020-04-28 7:00 ` James Hilliard
2020-04-28 7:10 ` Thomas Petazzoni [this message]
2020-04-28 7:55 ` Arnout Vandecappelle
2020-04-28 8:05 ` James Hilliard
2020-04-28 8:57 ` Thomas Petazzoni
2020-04-30 20:06 ` James Hilliard
2020-04-30 20:13 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428091022.4c613e80@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox