Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] configs/orangepi_rk3399: new defconfig
Date: Sat, 2 May 2020 23:34:09 +0200	[thread overview]
Message-ID: <20200502233409.4a90d4b2@windsurf.home> (raw)
In-Reply-To: <1588444408-20285-1-git-send-email-sunil@amarulasolutions.com>

Hello,

On Sun,  3 May 2020 00:03:28 +0530
sunil at amarulasolutions.com wrote:

>  N:	Suniel Mahesh <sunil@amarulasolutions.com>
>  F:	board/firefly/
> +F:	board/orangepi/

This puts you a contact for all board/orangepi/ boards, not just this
one. Is this expected?

> +# Bootloader
> +BR2_TARGET_UBOOT=y
> +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
> +BR2_TARGET_UBOOT_CUSTOM_VERSION=y
> +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2020.04"
> +BR2_TARGET_UBOOT_BOARD_DEFCONFIG="orangepi-rk3399"
> +BR2_TARGET_UBOOT_NEEDS_DTC=y
> +BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
> +BR2_TARGET_UBOOT_NEEDS_PYELFTOOLS=y

Are you sure these two options are needed? In fact the others rk3399
defconfigs are wrong, and all what they need is Python 3.x. Could you
check my series at:

  http://patchwork.ozlabs.org/project/buildroot/list/?series=174258

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2020-05-02 21:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-02 18:33 [Buildroot] [PATCH] configs/orangepi_rk3399: new defconfig sunil at amarulasolutions.com
2020-05-02 21:34 ` Thomas Petazzoni [this message]
2020-05-03  6:34   ` Suniel Mahesh
2020-05-03  9:11   ` [Buildroot] [PATCH v2 0/2] Add support for rockpro64 and oragepi-rk3399 targets sunil at amarulasolutions.com
2020-05-03  9:11     ` [Buildroot] [PATCH v2 1/2] configs/rockpro64: new defconfig sunil at amarulasolutions.com
2020-05-03  9:11     ` [Buildroot] [PATCH v2 2/2] configs/orangepi_rk3399: " sunil at amarulasolutions.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200502233409.4a90d4b2@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox