From: Aleksander Morgado <aleksander@aleksander.es>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/modem-manager: test for the used packages, not for the MM option
Date: Tue, 5 May 2020 14:07:20 +0200 [thread overview]
Message-ID: <20200505120720.258993-1-aleksander@aleksander.es> (raw)
This allows user to either explicitly select the libraries it
needs (e.g. libqmi and/or libmbim) and otherwise explicitly configure
to request the QMI/MBIM features in ModemManager.
This simplifies the build logic, and we avoid possible issues where a
user that did select the library forgot to select the MM feature.
Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
---
package/modem-manager/modem-manager.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/modem-manager/modem-manager.mk b/package/modem-manager/modem-manager.mk
index 75fc5811db..6b4e9b6250 100644
--- a/package/modem-manager/modem-manager.mk
+++ b/package/modem-manager/modem-manager.mk
@@ -13,7 +13,7 @@ MODEM_MANAGER_DEPENDENCIES = host-pkgconf libglib2 $(TARGET_NLS_DEPENDENCIES)
MODEM_MANAGER_INSTALL_STAGING = YES
MODEM_MANAGER_CONF_OPTS = --disable-more-warnings
-ifeq ($(BR2_PACKAGE_MODEM_MANAGER_LIBQMI),y)
+ifeq ($(BR2_PACKAGE_LIBQMI),y)
MODEM_MANAGER_DEPENDENCIES += libqmi
MODEM_MANAGER_CONF_OPTS += --with-qmi
else
@@ -27,7 +27,7 @@ else
MODEM_MANAGER_CONF_OPTS += --without-udev
endif
-ifeq ($(BR2_PACKAGE_MODEM_MANAGER_LIBMBIM),y)
+ifeq ($(BR2_PACKAGE_LIBMBIM),y)
MODEM_MANAGER_DEPENDENCIES += libmbim
MODEM_MANAGER_CONF_OPTS += --with-mbim
else
--
2.26.1
next reply other threads:[~2020-05-05 12:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 12:07 Aleksander Morgado [this message]
2020-07-27 19:12 ` [Buildroot] [PATCH] package/modem-manager: test for the used packages, not for the MM option Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200505120720.258993-1-aleksander@aleksander.es \
--to=aleksander@aleksander.es \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox