From: vadim4j at gmail.com <vadim4j@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/ndisc6: fix for codesourcery compilation
Date: Sat, 9 May 2020 21:24:52 +0300 [thread overview]
Message-ID: <20200509182452.GA347408@archlinux> (raw)
In-Reply-To: <20200509183943.126d56e0@windsurf.home>
On Sat, May 09, 2020 at 06:39:43PM +0200, Thomas Petazzoni wrote:
> On Sat, 9 May 2020 20:05:03 +0300
> Vadym Kochan <vadim4j@gmail.com> wrote:
>
> > trace-{udp,tcp}.c uses BSD-style headers, it builds ok on some
> > latest libc compilation because they use:
> >
> > __extension__ union
> >
> > but for example on codesourcery toolchain 4.x version it requires that
> > __FAVOR_BSD is defined. So fix it by defining this define only for
> > tcp/udp headers.
> >
> > Fixes: http://autobuild.buildroot.net/results/d05d5471d10a2b6634711ccad75d7f86d222cc31
> >
> > Signed-off-by: Vadym Kochan <vadim4j@gmail.com>
>
> Fixing issues for "codesourcery compilation" is wrong. What is being
> fixed is either a glibc-version related issue, or a gcc-version related
> issue. But we don't fix things for one specific toolchain.
>
> Could you investigate a bit more, and reword the patch and commit log
> accordingly ?
>
You are right, actually it was easier refer to codesourcery toolchain,
but yes the issue is related to glibc implementation in this case.
Will try to re-do the description.
next prev parent reply other threads:[~2020-05-09 18:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 17:05 [Buildroot] [PATCH] package/ndisc6: fix for codesourcery compilation Vadym Kochan
2020-05-09 16:39 ` Thomas Petazzoni
2020-05-09 18:24 ` vadim4j at gmail.com [this message]
2020-05-09 19:12 ` vadim4j at gmail.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200509182452.GA347408@archlinux \
--to=vadim4j@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox