From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/fakeroot: fix for fchownat/fchmodat
Date: Wed, 13 May 2020 22:27:09 +0200 [thread overview]
Message-ID: <20200513202709.GB12536@scaer> (raw)
In-Reply-To: <20200510203509.7628-1-nolange79@gmail.com>
Norbert, All,
On 2020-05-10 22:35 +0200, Norbert Lange spake thusly:
> fakeroot does mask out necessary flags, instead pass through
> the flags that are supported by fstatat
>
> Upstream BR: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=959876
I think you might get better/quicker feedback by opening a merge-request
on the gitlab repo;
https://salsa.debian.org/clint/fakeroot/
> Signed-off-by: Norbert Lange <nolange79@gmail.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> ...Fix-forwarding-fchownat-fchmod-flags.patch | 28 +++++++++++++++++++
> 1 file changed, 28 insertions(+)
> create mode 100644 package/fakeroot/0004-Fix-forwarding-fchownat-fchmod-flags.patch
>
> diff --git a/package/fakeroot/0004-Fix-forwarding-fchownat-fchmod-flags.patch b/package/fakeroot/0004-Fix-forwarding-fchownat-fchmod-flags.patch
> new file mode 100644
> index 0000000000..fc74543378
> --- /dev/null
> +++ b/package/fakeroot/0004-Fix-forwarding-fchownat-fchmod-flags.patch
> @@ -0,0 +1,28 @@
> +Forward supported flags to fstatat, this fixes issues like
> +using an empty path
> +
> +Upstream BR: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=959876
> +
> +Signed-off-by: Norbert Lange <nolange79@gmail.com>
> +
> +diff -burN fakeroot-1.20.2.org/libfakeroot.c fakeroot-1.20.2/libfakeroot.c
> +--- fakeroot-1.20.2.org/libfakeroot.c 2014-10-05 17:16:00.000000000 +0200
> ++++ fakeroot-1.20.2/libfakeroot.c 2020-05-10 22:24:18.896625085 +0200
> +@@ -880,7 +880,7 @@
> + /* If AT_SYMLINK_NOFOLLOW is set in the fchownat call it should
> + be when we stat it. */
> + INT_STRUCT_STAT st;
> +- r=INT_NEXT_FSTATAT(dir_fd, path, &st, (flags & AT_SYMLINK_NOFOLLOW));
> ++ r=INT_NEXT_FSTATAT(dir_fd, path, &st, (flags & (AT_SYMLINK_NOFOLLOW | AT_EMPTY_PATH | AT_NO_AUTOMOUNT)));
> +
> + if(r)
> + return(r);
> +@@ -1017,7 +1017,7 @@
> +
> + /* If AT_SYMLINK_NOFOLLOW is set in the fchownat call it should
> + be when we stat it. */
> +- r=INT_NEXT_FSTATAT(dir_fd, path, &st, flags & AT_SYMLINK_NOFOLLOW);
> ++ r=INT_NEXT_FSTATAT(dir_fd, path, &st, flags & (AT_SYMLINK_NOFOLLOW | AT_EMPTY_PATH | AT_NO_AUTOMOUNT));
> +
> + if(r)
> + return(r);
> --
> 2.26.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2020-05-13 20:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-10 20:35 [Buildroot] [PATCH] package/fakeroot: fix for fchownat/fchmodat Norbert Lange
2020-05-13 20:27 ` Yann E. MORIN [this message]
2020-05-22 7:44 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513202709.GB12536@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox