public inbox for buildroot@busybox.net
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/alsa-lib: build with versioned symbols
Date: Fri, 15 May 2020 21:46:57 +0200	[thread overview]
Message-ID: <20200515214657.17714f31@windsurf.home> (raw)
In-Reply-To: <20200515183353.4183611-1-joseph.kogut@gmail.com>

Hello,

+Max Filippov

On Fri, 15 May 2020 11:33:53 -0700
Joseph Kogut <joseph.kogut@gmail.com> wrote:

> Is there a reason to leave --without-versioned in the package, or make
> it an optional config? I can't imagine the size difference is all that
> great.

This --without-versioned was added in commit
e90a4bf4af3b6466b2a2d8df12cfe84f5d364cca back in February 2009 (wow, 11
years ago). This commit, from Peter Korsgaard, says:

commit e90a4bf4af3b6466b2a2d8df12cfe84f5d364cca
Author: Peter Korsgaard <jacmet@sunsite.dk>
Date:   Mon Feb 23 13:01:26 2009 +0000

    alsa-lib: don't use versioned symbols
    
    As reported by Dirk Vermaak and Daniel Mack. Fixes runtime issues with
    alsa-lib, see
    http://mailman.alsa-project.org/pipermail/alsa-devel/2009-February/014999.html
    for details.

The mailing list thread pointed by this link contains an interesting
explanation:
https://mailman.alsa-project.org/pipermail/alsa-devel/2009-February/015031.html,
i.e it wasn't working with uClibc because uClibc doesn't support
versioned symbols.

Interestingly, in 2015, the fact that uClibc doesn't support versioned
symbol also caused some issue with elfutils, as was reported by Max
Filippov at:

https://lists.fedorahosted.org/archives/list/elfutils-devel at lists.fedorahosted.org/thread/XIK5GQRWKOMOZ4FVBRWTPOH57DUYFNZV/

So it seems like this problem still exists.

Also, in 2017, Alexey Brokdin also reminded about this in his talk on
uClibc, see
https://elinux.org/images/9/9f/Uclibc-still-makes-sense-brodkin-elce2017_0.pdf

So, we unfortunately can't apply your patch as-is. Perhaps we should
make that conditional on uClibc ? Indeed, I assume that CEF will never
work with uClibc anyway :-)

I am puzzled though: if alsa-lib is built without symbol versioning,
how can CEF "know" about such versioning ? It is hardcoded into the CEF
source code ?

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2020-05-15 19:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-15 18:33 [Buildroot] [PATCH 1/1] package/alsa-lib: build with versioned symbols Joseph Kogut
2020-05-15 19:46 ` Thomas Petazzoni [this message]
2020-05-18  5:11 ` [Buildroot] [PATCH v2 1/1] package/alsa-lib: disable versioned symbols only when unsupported Joseph Kogut
2022-01-08 10:04   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200515214657.17714f31@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox