* [Buildroot] [PATCH 1/2] package/rpi-firmware: select BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT when needed
@ 2020-05-16 14:02 Thomas Petazzoni
2020-05-16 14:02 ` [Buildroot] [PATCH 2/2] configs/raspberrypi{3, 4}_64: enabling BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT no longer needed Thomas Petazzoni
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2020-05-16 14:02 UTC (permalink / raw)
To: buildroot
When BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS is enabled, and the
DTBs are built by Linux (i.e BR2_LINUX_KERNEL_DTS_SUPPORT is enabled),
these DTBs should be built with the -@ Device Tree compiler option, so
that they can be used together with DTB overlays. So let's select
BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT in this situation.
Fixes:
https://bugs.busybox.net/show_bug.cgi?id=12831
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
package/rpi-firmware/Config.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/rpi-firmware/Config.in b/package/rpi-firmware/Config.in
index 7cebc5e7ca..cced53f017 100644
--- a/package/rpi-firmware/Config.in
+++ b/package/rpi-firmware/Config.in
@@ -85,6 +85,8 @@ config BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS
default y
depends on BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS \
|| BR2_LINUX_KERNEL_DTS_SUPPORT
+ select BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT \
+ if BR2_LINUX_KERNEL_DTS_SUPPORT
help
Say 'y' here if you need to load one or more of the DTB
overlays, to support HATs (Hardware Attached on Top, add-on
--
2.26.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Buildroot] [PATCH 2/2] configs/raspberrypi{3, 4}_64: enabling BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT no longer needed
2020-05-16 14:02 [Buildroot] [PATCH 1/2] package/rpi-firmware: select BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT when needed Thomas Petazzoni
@ 2020-05-16 14:02 ` Thomas Petazzoni
2020-05-29 20:59 ` Peter Korsgaard
2020-05-16 19:43 ` [Buildroot] [PATCH 1/2] package/rpi-firmware: select BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT when needed Yann E. MORIN
2020-05-29 20:59 ` Peter Korsgaard
2 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2020-05-16 14:02 UTC (permalink / raw)
To: buildroot
BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT is now forcefully selected by
BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS when the kernel is in
charge of building DTBs (BR2_LINUX_KERNEL_DTS_SUPPORT=y). So enabling
BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT is no longer needed in the 64-bit
defconfigs for Raspberry Pi 3 and 4.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
configs/raspberrypi3_64_defconfig | 1 -
configs/raspberrypi4_64_defconfig | 1 -
2 files changed, 2 deletions(-)
diff --git a/configs/raspberrypi3_64_defconfig b/configs/raspberrypi3_64_defconfig
index 10e6079d54..27bd5aa0bb 100644
--- a/configs/raspberrypi3_64_defconfig
+++ b/configs/raspberrypi3_64_defconfig
@@ -17,7 +17,6 @@ BR2_LINUX_KERNEL_DEFCONFIG="bcmrpi3"
# Build the DTB from the kernel sources
BR2_LINUX_KERNEL_DTS_SUPPORT=y
BR2_LINUX_KERNEL_INTREE_DTS_NAME="broadcom/bcm2710-rpi-3-b broadcom/bcm2710-rpi-3-b-plus broadcom/bcm2837-rpi-3-b"
-BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT=y
BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
diff --git a/configs/raspberrypi4_64_defconfig b/configs/raspberrypi4_64_defconfig
index fd6f8e4dce..283ef4ba36 100644
--- a/configs/raspberrypi4_64_defconfig
+++ b/configs/raspberrypi4_64_defconfig
@@ -17,7 +17,6 @@ BR2_LINUX_KERNEL_DEFCONFIG="bcm2711"
# Build the DTB from the kernel sources
BR2_LINUX_KERNEL_DTS_SUPPORT=y
BR2_LINUX_KERNEL_INTREE_DTS_NAME="broadcom/bcm2711-rpi-4-b"
-BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT=y
BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
--
2.26.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Buildroot] [PATCH 1/2] package/rpi-firmware: select BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT when needed
2020-05-16 14:02 [Buildroot] [PATCH 1/2] package/rpi-firmware: select BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT when needed Thomas Petazzoni
2020-05-16 14:02 ` [Buildroot] [PATCH 2/2] configs/raspberrypi{3, 4}_64: enabling BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT no longer needed Thomas Petazzoni
@ 2020-05-16 19:43 ` Yann E. MORIN
2020-05-29 20:59 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2020-05-16 19:43 UTC (permalink / raw)
To: buildroot
Thomas, All,
On 2020-05-16 16:02 +0200, Thomas Petazzoni spake thusly:
> When BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS is enabled, and the
> DTBs are built by Linux (i.e BR2_LINUX_KERNEL_DTS_SUPPORT is enabled),
> these DTBs should be built with the -@ Device Tree compiler option, so
> that they can be used together with DTB overlays. So let's select
> BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT in this situation.
>
> Fixes:
>
> https://bugs.busybox.net/show_bug.cgi?id=12831
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Both appiled to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/rpi-firmware/Config.in | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/package/rpi-firmware/Config.in b/package/rpi-firmware/Config.in
> index 7cebc5e7ca..cced53f017 100644
> --- a/package/rpi-firmware/Config.in
> +++ b/package/rpi-firmware/Config.in
> @@ -85,6 +85,8 @@ config BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS
> default y
> depends on BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS \
> || BR2_LINUX_KERNEL_DTS_SUPPORT
> + select BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT \
> + if BR2_LINUX_KERNEL_DTS_SUPPORT
> help
> Say 'y' here if you need to load one or more of the DTB
> overlays, to support HATs (Hardware Attached on Top, add-on
> --
> 2.26.2
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 5+ messages in thread* [Buildroot] [PATCH 1/2] package/rpi-firmware: select BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT when needed
2020-05-16 14:02 [Buildroot] [PATCH 1/2] package/rpi-firmware: select BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT when needed Thomas Petazzoni
2020-05-16 14:02 ` [Buildroot] [PATCH 2/2] configs/raspberrypi{3, 4}_64: enabling BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT no longer needed Thomas Petazzoni
2020-05-16 19:43 ` [Buildroot] [PATCH 1/2] package/rpi-firmware: select BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT when needed Yann E. MORIN
@ 2020-05-29 20:59 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2020-05-29 20:59 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> When BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS is enabled, and the
> DTBs are built by Linux (i.e BR2_LINUX_KERNEL_DTS_SUPPORT is enabled),
> these DTBs should be built with the -@ Device Tree compiler option, so
> that they can be used together with DTB overlays. So let's select
> BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT in this situation.
> Fixes:
> https://bugs.busybox.net/show_bug.cgi?id=12831
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed to 2020.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-29 20:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-16 14:02 [Buildroot] [PATCH 1/2] package/rpi-firmware: select BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT when needed Thomas Petazzoni
2020-05-16 14:02 ` [Buildroot] [PATCH 2/2] configs/raspberrypi{3, 4}_64: enabling BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT no longer needed Thomas Petazzoni
2020-05-29 20:59 ` Peter Korsgaard
2020-05-16 19:43 ` [Buildroot] [PATCH 1/2] package/rpi-firmware: select BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT when needed Yann E. MORIN
2020-05-29 20:59 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox