From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 3/9] package/collectd: depend on luainterpreter for lua support
Date: Mon, 25 May 2020 09:10:50 +0200 [thread overview]
Message-ID: <20200525091050.26175643@windsurf.home> (raw)
In-Reply-To: <20200525004845.3019642-3-james.hilliard1@gmail.com>
On Sun, 24 May 2020 18:48:39 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:
> config BR2_PACKAGE_COLLECTD_LUA
> bool "lua"
> - select BR2_PACKAGE_LUA
> + depends on BR2_PACKAGE_HAS_LUAINTERPRETER
> help
> Embeds a Lua interpreter into collectd and provides an
> interface to collectd's plugin system.
>
> +comment "lua needs a Lua interpreter"
> + depends on !BR2_PACKAGE_HAS_LUAINTERPRETER
I believe this comment is not needed, it is obvious a Lua interpreter
is needed for Lua support.
> - $(if $(BR2_PACKAGE_COLLECTD_LUA),lua) \
> + $(if $(BR2_PACKAGE_COLLECTD_LUA),$(if $(BR2_PACKAGE_LUA),lua,luajit)) \
Use the luainterpreter virtual package as a dependency here.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-05-25 7:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 0:48 [Buildroot] [PATCH v3 1/9] package/luainterpreter: add abi version options James Hilliard
2020-05-25 0:48 ` [Buildroot] [PATCH v3 2/9] package/sysdig: depend on lua ABI version 5.1 James Hilliard
2020-05-25 0:48 ` [Buildroot] [PATCH v3 3/9] package/collectd: depend on luainterpreter for lua support James Hilliard
2020-05-25 7:10 ` Thomas Petazzoni [this message]
2020-05-25 8:05 ` James Hilliard
2020-05-25 0:48 ` [Buildroot] [PATCH v3 4/9] package/solarus: depend on lua ABI version 5.1 James Hilliard
2020-05-25 0:48 ` [Buildroot] [PATCH v3 5/9] package/luaposix: select bit32 based " James Hilliard
2020-05-25 0:48 ` [Buildroot] [PATCH v3 6/9] package/minetest: do not select luajit James Hilliard
2020-06-06 17:05 ` Romain Naour
2020-06-06 22:43 ` James Hilliard
2020-07-27 20:11 ` Yann E. MORIN
2020-07-27 20:39 ` James Hilliard
2020-05-25 0:48 ` [Buildroot] [PATCH v3 7/9] package/efl: depend on lua ABI version 5.1 James Hilliard
2020-06-06 16:36 ` Romain Naour
2020-07-27 19:16 ` Yann E. MORIN
2020-07-27 19:19 ` Yann E. MORIN
2020-07-27 19:23 ` James Hilliard
2020-07-27 19:29 ` Yann E. MORIN
2020-07-27 19:36 ` James Hilliard
2020-07-27 19:44 ` Yann E. MORIN
2020-05-25 0:48 ` [Buildroot] [PATCH v3 8/9] package/prosody: don't depend on !lua 5.3 James Hilliard
2020-05-25 0:48 ` [Buildroot] [PATCH v3 9/9] package/luajit: depend on !BR2_PACKAGE_LUA James Hilliard
2020-07-27 20:37 ` Yann E. MORIN
2020-07-27 21:12 ` James Hilliard
2020-06-06 21:59 ` [Buildroot] [PATCH v3 1/9] package/luainterpreter: add abi version options Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200525091050.26175643@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox