Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] package/mesa3d: propagate missing libdrm-freedreno deps
Date: Tue, 26 May 2020 22:44:58 +0200	[thread overview]
Message-ID: <20200526204458.GE8737@scaer> (raw)
In-Reply-To: <20200526202437.4126010-1-james.hilliard1@gmail.com>

James, All,

On 2020-05-26 14:24 -0600, James Hilliard spake thusly:
> Libdrm freedreno depends on BR2_arm || BR2_aarch64 || BR2_aarch64_be
> as such we need to propagate those dependencies to mesa's gallium
> freedreno driver.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
> Changes v1 -> v2:
>   - add note about LIBDRM_HAS_ATOMIC dependency
> ---
>  package/mesa3d/Config.in | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
> index dd512d9b76..11d04b7a3f 100644
> --- a/package/mesa3d/Config.in
> +++ b/package/mesa3d/Config.in
> @@ -111,6 +111,12 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV
>  
>  config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_FREEDRENO
>  	bool "Gallium freedreno driver"
> +	depends on BR2_arm || BR2_aarch64 || BR2_aarch64_be # libdrm-freedreno
> +	# libdrm's freedreno option depends on LIBDRM_HAS_ATOMIC. Propagating
> +	# that dependency here causes a circular dependency that Kconfig
> +	# can't see is just spurious. However, that dependency is about
> +	# the toolchain having sync4 primitives, which is always a given
> +	# for arm/aarch64.
>  	select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
>  	select BR2_PACKAGE_LIBDRM_FREEDRENO
>  	select BR2_PACKAGE_MESA3D_GALLIUM_KMSRO
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2020-05-26 20:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-26 20:24 [Buildroot] [PATCH v2 1/1] package/mesa3d: propagate missing libdrm-freedreno deps James Hilliard
2020-05-26 20:44 ` Yann E. MORIN [this message]
2020-06-01 20:03 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200526204458.GE8737@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox