From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] package/cvs: fix mktime related compile failure
Date: Thu, 28 May 2020 22:43:35 +0200 [thread overview]
Message-ID: <20200528224335.2bb72177@windsurf.home> (raw)
In-Reply-To: <20200528203204.18142-1-ps.report@gmx.net>
On Thu, 28 May 2020 22:32:04 +0200
Peter Seiderer <ps.report@gmx.net> wrote:
> Use ac_cv_func_working_mktime=yes to force the use of a provided
> mktime implementation instead of compiling the failing own one.
>
> Fixes:
>
> http://autobuild.buildroot.net/results/5bcd8f4235002da682cc900f866116d2fe87f1c8
>
> mktime.c: In function 'ydhms_diff':
> mktime.c:106:52: error: size of array 'a' is negative
> #define verify(name, assertion) struct name { char a[(assertion) ? 1 : -1]; }
> ^
> mktime.c:170:3: note: in expansion of macro 'verify'
> verify (long_int_year_and_yday_are_wide_enough,
> ^~~~~~
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
Why is this suddenly failing? We have had this package for ages, it
hasn't been changed recently.
So instead of just fixing the issue, we always want to understand *why*
we started having an issue.
Do you have some details of this ?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-05-28 20:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 20:32 [Buildroot] [PATCH v1] package/cvs: fix mktime related compile failure Peter Seiderer
2020-05-28 20:43 ` Thomas Petazzoni [this message]
2020-05-28 21:16 ` Peter Seiderer
2020-05-28 21:29 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528224335.2bb72177@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox