Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] suport/download: fix git wrapper with submodules on older git versions
Date: Sat, 30 May 2020 23:08:31 +0200	[thread overview]
Message-ID: <20200530210831.GU8737@scaer> (raw)
In-Reply-To: <20200529234149.7437a5b4@windsurf.home>

Thomas, All,

On 2020-05-29 23:41 +0200, Thomas Petazzoni spake thusly:
> On Sun, 24 May 2020 13:47:18 +0200
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> > +    # Older versions of git will store the absolute path of the git tree
> > +    # in the .git of submodules, while newer versions just use relative
> > +    # paths. Detect and fix the older variants to use relative paths, so
> > +    # that the archives are reproducible across a wider range of git
> > +    # versions. However, we can't do that if git is too old and uses
> > +    # full repositories for submodules.
> 
> If I understand correctly, there are three "eras":
> 
>  - Really old Git versions, where full repositories are used for
>    submodules, where we can't do anything.
> 
>  - Old Git versions, that stored absolute paths.
> 
>  - Recent Git versions, that store relative paths.

Spot-on.

> Would it be possible to identify which versions we're talking about
> here? I'm sure you've done that research, and I think it makes sense to
> capture that, as we will certainly wonder what we mean by "older
> versions", "old version", "new version.
> 
> What is new, old, or older today, will feel quite different 5 years
> from now.

Sorry, you presumed too much: I haven't dug the nitty-gritty details on
when git transitioned from one area to another...

I just stumbled on this issue while working on the conversion of the
archives generated from a git tree, which got me scratch my head for
quite some time... I should have noted the conditions back then, true,
but I forgot...

Regards,
Yann E. MORIN.

> Thomas
> -- 
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2020-05-30 21:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-24 11:47 [Buildroot] [PATCH] suport/download: fix git wrapper with submodules on older git versions Yann E. MORIN
2020-05-25  1:55 ` Vincent Fazio
2020-05-25 20:05   ` Yann E. MORIN
2020-05-25 23:24     ` Vincent Fazio
2020-05-29 21:41 ` Thomas Petazzoni
2020-05-30 21:08   ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200530210831.GU8737@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox