From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH V5] package/c-periphery: bump version to 2.2.1
Date: Tue, 2 Jun 2020 23:20:51 +0200 [thread overview]
Message-ID: <20200602232051.6cec350c@windsurf.home> (raw)
In-Reply-To: <20200601074841.6325-1-offougajoris@gmail.com>
On Mon, 1 Jun 2020 09:48:40 +0200
Joris Offouga <offougajoris@gmail.com> wrote:
> Since commit "cmake: add cmake build support"
> (https://github.com/vsergeev/c-periphery/commit/952e1e906a5d65b78932128af24b7dbb8cce2e9dvsergeev/c-periphery at d0a973c),
> c-periphery implement cmake build, so use cmake-package instead of generic-package
You should have also explained that it now builds a shared library and
therefore INSTALL_TARGET = NO is no longer appropriate. I fixed that.
> +C_PERIPHERY_INSTALL_TARGET = YES
This raises a check-package warning, because this is the default value.
So I simply dropped this line when applying.
Applied to master. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2020-06-02 21:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 7:48 [Buildroot] [PATCH V5] package/c-periphery: bump version to 2.2.1 Joris Offouga
2020-06-02 21:20 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602232051.6cec350c@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox