From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/edid-decode: bump version to 1889504
Date: Wed, 3 Jun 2020 12:40:37 +0200 [thread overview]
Message-ID: <20200603124037.7916fddc@gmx.net> (raw)
In-Reply-To: <20200603101945.zu3uwm23vsweqzhm@sapphire.tkos.co.il>
Hello Baruch,
On Wed, 3 Jun 2020 13:19:45 +0300, Baruch Siach <baruch@tkos.co.il> wrote:
> Hi Peter,
>
> On Wed, Jun 03, 2020 at 12:14:46PM +0200, Peter Seiderer wrote:
> > - edid-decode changed from C to C++, adjust make command
> > accordingly and add BR2_INSTALL_LIBSTDCPP dependency
> >
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> > ---
> > Changes v1 -> v2:
> > - add BR2_INSTALL_LIBSTDCPP dependency (suggestd by Thomas Petazzoni)
> > ---
> > package/edid-decode/Config.in | 4 ++++
> > package/edid-decode/edid-decode.hash | 2 +-
> > package/edid-decode/edid-decode.mk | 4 ++--
> > 3 files changed, 7 insertions(+), 3 deletions(-)
> >
> > diff --git a/package/edid-decode/Config.in b/package/edid-decode/Config.in
> > index 701c70031f..d2d21288de 100644
> > --- a/package/edid-decode/Config.in
> > +++ b/package/edid-decode/Config.in
> > @@ -1,6 +1,10 @@
> > config BR2_PACKAGE_EDID_DECODE
> > bool "edid-decode"
> > + depends on BR2_INSTALL_LIBSTDCPP
> > help
> > Decode EDID data in human-readable format.
> >
> > https://git.linuxtv.org/edid-decode.git/
> > +
> > +comment "edid-decode needs a toolchain w/ C++"
> > + depends on !!BR2_INSTALL_LIBSTDCPP
> > diff --git a/package/edid-decode/edid-decode.hash b/package/edid-decode/edid-decode.hash
> > index e0a9c18523..f843aa68fd 100644
> > --- a/package/edid-decode/edid-decode.hash
> > +++ b/package/edid-decode/edid-decode.hash
> > @@ -1,3 +1,3 @@
> > # Locally computed
> > -sha256 27fcf4c8693ec6fe020b18c78c70ddba9a8b3ea8c55fcfad2a38103128ec5e36 edid-decode-6def7bc83dfb0338632e06a8b14c93faa6af8879.tar.gz
> > +sha256 327fe14531ddebe74a730efc30209e68efbd86c11375b5576cbe23af3d691150 edid-decode-188950472c19492547e298b27f9da0d72cf826df.tar.gz
> > sha256 4b4a7e6d7c358bb5b982eaa84d228cd9e99b75a5fefd3af01272957bf2016b5b edid-decode.c
>
> This file is gone in the revision you bump to. There is now a LICENSE file
> that we should be using instead.
Your are right, v3 follows...thanks for review...
Regards,
Peter
>
> baruch
>
> > diff --git a/package/edid-decode/edid-decode.mk b/package/edid-decode/edid-decode.mk
> > index c43f1ae7da..e15cb70f84 100644
> > --- a/package/edid-decode/edid-decode.mk
> > +++ b/package/edid-decode/edid-decode.mk
> > @@ -4,14 +4,14 @@
> > #
> > ################################################################################
> >
> > -EDID_DECODE_VERSION = 6def7bc83dfb0338632e06a8b14c93faa6af8879
> > +EDID_DECODE_VERSION = 188950472c19492547e298b27f9da0d72cf826df
> > EDID_DECODE_SITE = git://linuxtv.org/edid-decode.git
> > EDID_DECODE_LICENSE = MIT
> > EDID_DECODE_LICENSE_FILES = edid-decode.c
> >
> > define EDID_DECODE_BUILD_CMDS
> > $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
> > - CC="$(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS)"
> > + CXX="$(TARGET_CXX) $(TARGET_CXXFLAGS) $(TARGET_LDFLAGS)"
> > endef
> >
> > define EDID_DECODE_INSTALL_TARGET_CMDS
> > --
> > 2.26.2
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
>
prev parent reply other threads:[~2020-06-03 10:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 10:14 [Buildroot] [PATCH v2] package/edid-decode: bump version to 1889504 Peter Seiderer
2020-06-03 10:19 ` Baruch Siach
2020-06-03 10:40 ` Peter Seiderer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200603124037.7916fddc@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox