From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 3/3] package/bcm2835: add cap_sys_rawio capability support
Date: Wed, 3 Jun 2020 23:14:06 +0200 [thread overview]
Message-ID: <20200603211406.GF13972@scaer> (raw)
In-Reply-To: <20200603103849.20415-3-ps.report@gmx.net>
Peter, All,
On 2020-06-03 12:38 +0200, Peter Seiderer spake thusly:
> Add cap_sys_rawio capability support in case libcap is available.
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> Changes v1 -> v2:
> - split of from original patch and fixed for
> BCM2835_HAVE_LIBCAP/BCM2835_HAVE_LIBCAP2 typo
> ---
> package/bcm2835/bcm2835.mk | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/package/bcm2835/bcm2835.mk b/package/bcm2835/bcm2835.mk
> index 2ef6d94b38..1cabd72e5d 100644
> --- a/package/bcm2835/bcm2835.mk
> +++ b/package/bcm2835/bcm2835.mk
> @@ -13,4 +13,10 @@ BCM2835_INSTALL_STAGING = YES
> # disable doxygen doc generation
> BCM2835_CONF_ENV = ac_cv_prog_DOXYGEN=/bin/true
>
> +ifeq ($(BR2_PACKAGE_LIBCAP),y)
> +BCM2835_DEPENDENCIES = libcap
> +# workaround typo in src/bcm2835.c and use both defines
> +BCM2835_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -DBCM2835_HAVE_LIBCAP -DBCM2835_HAVE_LIBCAP2"
As reported by Thomas, this is just a stupid bug in the code. It should
be fixed by sending upstream a patch.
(note: this is hilarious... not.)
Regards,
Yann E. MORIN.
> +endif
> +
> $(eval $(autotools-package))
> --
> 2.26.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2020-06-03 21:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 10:38 [Buildroot] [PATCH v2 1/3] package/bcm2835: disable doxygen doc generation Peter Seiderer
2020-06-03 10:38 ` [Buildroot] [PATCH v2 2/3] package/bcm2835: bump version to 1.65 Peter Seiderer
2020-06-03 21:32 ` Yann E. MORIN
2020-06-03 10:38 ` [Buildroot] [PATCH v2 3/3] package/bcm2835: add cap_sys_rawio capability support Peter Seiderer
2020-06-03 21:14 ` Yann E. MORIN [this message]
2020-06-03 21:25 ` [Buildroot] [PATCH v2 1/3] package/bcm2835: disable doxygen doc generation Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200603211406.GF13972@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox