From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Revert "package/prosody: use correct bit32 package"
Date: Thu, 4 Jun 2020 23:28:10 +0200 [thread overview]
Message-ID: <20200604232810.74247dc5@windsurf> (raw)
In-Reply-To: <20200603215904.98199-1-romain.naour@gmail.com>
On Wed, 3 Jun 2020 23:59:04 +0200
Romain Naour <romain.naour@gmail.com> wrote:
> This reverts commit fa84c176c2148a60103e850204180f86aa5baa73 that
> replace luabitop by lua_bit32 package when lua 5.1 is used.
>
> Since this change the prosody test in gitlab is fail due to
> missing lua-bitops [1]:
>
> Starting prosody:
> **************************
> Prosody was unable to find lua-bitops
> This package can be obtained in the following ways:
>
> Source: http://bitop.luajit.org/
> Debian/Ubuntu: sudo apt-get install lua-bitop
> luarocks: luarocks install luabitop
>
> WebSocket support will not be available
> More help can be found on our website, at https://prosody.im/doc/depends
> **************************
>
> The upstream documentation [2] is misleading (or not uptodate)
> about lua-bit32 dependency.
>
> Since bitop is builtin since lua5.2, we probably need to select
> luabitop package only when lua 5.1 is used as lua interpreter.
>
> Tested with run-tests:
> ./support/testing/run-tests tests.package.test_prosody.TestProsodyLua51
>
> [1] https://gitlab.com/buildroot.org/buildroot/-/jobs/576271975
> [2] https://prosody.im/doc/depends#bitop
>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: James Hilliard <james.hilliard1@gmail.com>
> Cc: Yann E. MORIN <yann.morin.1998@free.fr>
> ---
> package/prosody/Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-06-04 21:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 21:59 [Buildroot] [PATCH] Revert "package/prosody: use correct bit32 package" Romain Naour
2020-06-03 22:30 ` James Hilliard
2020-06-03 22:42 ` Romain Naour
2020-06-04 0:18 ` James Hilliard
2020-06-04 21:02 ` Romain Naour
2020-06-04 5:00 ` François Perrad
2020-06-04 9:21 ` Thomas Petazzoni
2020-06-04 21:28 ` Thomas Petazzoni [this message]
2020-06-06 21:34 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200604232810.74247dc5@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox