From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] fs/ubi: expose BINARIES_DIR to ubinize.cfg
Date: Sat, 6 Jun 2020 13:46:36 +0200 [thread overview]
Message-ID: <20200606114636.GC13972@scaer> (raw)
In-Reply-To: <20200606105015.1603519-1-alexandre.belloni@bootlin.com>
Alexandre, All,
On 2020-06-06 12:50 +0200, Alexandre Belloni spake thusly:
> It is often necessary to refer to other images that are present in
> BINARIES_DIR from a custom ubinize configuration e.g. to include the kernel
> in a UBI volume.
>
> As for BR2_ROOTFS_UBIFS_PATH, replace BINARIES_DIR when copying the file.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
You forgot to update the help text to also mention this replacement, so
I did add a blurb there, and applied to master (with a rewrpaeed commit
log, too). Thanks.
Regards,
Yann E. MORIN.
> ---
> fs/ubi/ubi.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ubi/ubi.mk b/fs/ubi/ubi.mk
> index d848f8b23a65..54bb81ea08a4 100644
> --- a/fs/ubi/ubi.mk
> +++ b/fs/ubi/ubi.mk
> @@ -23,7 +23,7 @@ endif
> # don't use sed -i as it misbehaves on systems with SELinux enabled when this is
> # executed through fakeroot (see #9386)
> define ROOTFS_UBI_CMD
> - sed 's;BR2_ROOTFS_UBIFS_PATH;$@fs;' \
> + sed 's;BR2_ROOTFS_UBIFS_PATH;$@fs;;s;BINARIES_DIR;$(BINARIES_DIR);' \
> $(UBI_UBINIZE_CONFIG_FILE_PATH) > $(BUILD_DIR)/ubinize.cfg
> $(HOST_DIR)/sbin/ubinize -o $@ $(UBI_UBINIZE_OPTS) $(BUILD_DIR)/ubinize.cfg
> rm $(BUILD_DIR)/ubinize.cfg
> --
> 2.26.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2020-06-06 11:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-06 10:50 [Buildroot] [PATCH] fs/ubi: expose BINARIES_DIR to ubinize.cfg Alexandre Belloni
2020-06-06 11:46 ` Yann E. MORIN [this message]
2020-07-05 20:59 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200606114636.GC13972@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox