From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2, 1/2] package/edid-decode: use TARGET_CONFIGURE_OPTS
Date: Sat, 6 Jun 2020 21:41:24 +0200 [thread overview]
Message-ID: <20200606214124.7ca0bef0@gmx.net> (raw)
In-Reply-To: <20200606122810.2745801-1-fontaine.fabrice@gmail.com>
Hello Fabrice,
On Sat, 6 Jun 2020 14:28:09 +0200, Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Do not use CXX to save the "$(TARGET_CXX) $(TARGET_CXXFLAGS)
> $(TARGET_LDFLAGS)" tuple and instead use TARGET_CONFIGURE_OPTS to pass
> variables using the "standard" variables
>
> LDFLAGS is supported since
> https://git.linuxtv.org/edid-decode.git/commit/?id=0a454bcbba5e172c64236811ed98c161689372f1
>
> CFLAGS is supported since
> https://git.linuxtv.org/edid-decode.git/commit/?id=b202b675e38578b33494fc45c2869917e66ba22d
>
> edid-decode did not switch CFLAGS to CXXFLAGS in
> https://git.linuxtv.org/edid-decode.git/commit/Makefile?id=e00579c128ced87a69df29a01caaaf0cd4a4c8cc
> so use CFLAGS to pass TARGET_CXXFLAGS
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Peter Seiderer):
> - Drop link on autobuilder failure
>
> package/edid-decode/edid-decode.mk | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/package/edid-decode/edid-decode.mk b/package/edid-decode/edid-decode.mk
> index 8fe1e2712a..c41a9f2a76 100644
> --- a/package/edid-decode/edid-decode.mk
> +++ b/package/edid-decode/edid-decode.mk
> @@ -10,12 +10,13 @@ EDID_DECODE_LICENSE = MIT
> EDID_DECODE_LICENSE_FILES = LICENSE
>
> define EDID_DECODE_BUILD_CMDS
> - $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
> - CXX="$(TARGET_CXX) $(TARGET_CXXFLAGS) $(TARGET_LDFLAGS)"
> + $(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
> + CFLAGS="$(TARGET_CXXFLAGS)"
> endef
>
> define EDID_DECODE_INSTALL_TARGET_CMDS
> - $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR="$(TARGET_DIR)" install
> + $(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
> + DESTDIR="$(TARGET_DIR)" install
No need for the 'TARGET_CONFIGURE_OPTS' here (as the install only uses DESTDIR)...
With this fixed and because the same effective compile options are used
as without the patch you can add my:
Tested-by: Peter Seiderer <ps.report@gmx.net>
Regards,
Peter
> endef
>
> $(eval $(generic-package))
prev parent reply other threads:[~2020-06-06 19:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-06 12:28 [Buildroot] [PATCH v2, 1/2] package/edid-decode: use TARGET_CONFIGURE_OPTS Fabrice Fontaine
2020-06-06 12:28 ` [Buildroot] [PATCH v2, 2/2] package/edid-decode: fix build with gcc <= 5 Fabrice Fontaine
2020-06-06 19:44 ` Peter Seiderer
2020-06-06 19:41 ` Peter Seiderer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200606214124.7ca0bef0@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox