From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/eigen: fix package detection with CMake
Date: Sun, 14 Jun 2020 09:28:36 +0200 [thread overview]
Message-ID: <20200614072836.GB2346@scaer> (raw)
In-Reply-To: <20200613161643.609929-1-juju@cotds.org>
Julien, Matt, all,
On 2020-06-13 18:16 +0200, Julien Olivain spake thusly:
> Eigen3 library normally installs a signature file named
> "signature_of_eigen3_matrix_library" to help library detection:
> https://gitlab.com/libeigen/eigen/-/blob/3.3.7/CMakeLists.txt#L423
>
> This Buildroot package does not use CMake for installing files, as only
> the headers are needed in the STAGING_DIR. A generic-package is used
> instead with simple copies.
Why can't we use the cmake-package infra, rahter than duplicate what
upstream does?
Regards,
Yann E. MORIN.
> The library also provide a CMake macro that use this file to
> detect it:
> https://gitlab.com/libeigen/eigen/-/blob/3.3.7/cmake/FindEigen3.cmake#L76
>
> Without the signature file installed, packages searching for this
> library with this method will fail. Other packages usings pkg-config are
> not affected by this issue.
>
> This patch install the signature file at the expected path, to fix
> detections.
>
> Signed-off-by: Julien Olivain <juju@cotds.org>
> ---
> package/eigen/eigen.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/eigen/eigen.mk b/package/eigen/eigen.mk
> index 5c9e028442..68ffe84cb4 100644
> --- a/package/eigen/eigen.mk
> +++ b/package/eigen/eigen.mk
> @@ -34,6 +34,7 @@ define EIGEN_INSTALL_STAGING_CMDS
> $(RM) -r $(EIGEN_DEST_DIR)
> mkdir -p $(EIGEN_DEST_DIR)
> cp -a $(@D)/Eigen $(EIGEN_DEST_DIR)
> + cp -a $(@D)/signature_of_eigen3_matrix_library $(EIGEN_DEST_DIR)
> $(EIGEN_INSTALL_UNSUPPORTED_MODULES_CMDS)
> $(INSTALL) -D -m 0644 $(@D)/eigen3.pc \
> $(STAGING_DIR)/usr/lib/pkgconfig/eigen3.pc
> --
> 2.26.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2020-06-14 7:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-13 16:16 [Buildroot] [PATCH 1/1] package/eigen: fix package detection with CMake Julien Olivain
2020-06-14 7:28 ` Yann E. MORIN [this message]
2020-06-14 10:54 ` Julien Olivain
2020-06-14 17:37 ` [Buildroot] [PATCH v2] package/eigen: use cmake-package infra Julien Olivain
2020-06-14 21:15 ` Yann E. MORIN
2020-06-15 18:47 ` Julien Olivain
2020-06-15 18:49 ` [Buildroot] [PATCH v3] " Julien Olivain
2020-06-15 23:50 ` Matthew Weber
2020-06-16 6:54 ` Yann E. MORIN
2020-06-16 6:53 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200614072836.GB2346@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox