Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/libwebsockets: Add support for unix-domain-sockets
Date: Sun, 14 Jun 2020 10:21:04 +0200	[thread overview]
Message-ID: <20200614082104.GE2346@scaer> (raw)
In-Reply-To: <20200612113153.3220089-1-heiko@sntech.de>

Heiko, Martin, All,

On 2020-06-12 13:31 +0200, Heiko Stuebner spake thusly:
> From: Martin Elshuber <martin.elshuber@theobroma-systems.com>
> 
> libwebsockets allows the usage of unix-domain-sockets since 2016,
> so add an option to enable its usage.
> 
> Signed-off-by: Martin Elshuber <martin.elshuber@theobroma-systems.com>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> ---
>  package/libwebsockets/Config.in        | 4 ++++
>  package/libwebsockets/libwebsockets.mk | 4 ++++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/package/libwebsockets/Config.in b/package/libwebsockets/Config.in
> index 2b350bf389..78a659fd35 100644
> --- a/package/libwebsockets/Config.in
> +++ b/package/libwebsockets/Config.in
> @@ -8,3 +8,7 @@ config BR2_PACKAGE_LIBWEBSOCKETS
>  	  in both directions.
>  
>  	  http://libwebsockets.org/
> +
> +config BR2_PACKAGE_LIBWEBSOCKETS_INCLUDE_UNIX_SOCK
> +       bool "include support for unix-sockets"
> +       depends on BR2_PACKAGE_LIBWEBSOCKETS
> diff --git a/package/libwebsockets/libwebsockets.mk b/package/libwebsockets/libwebsockets.mk
> index dedd03347d..3f6ab1408d 100644
> --- a/package/libwebsockets/libwebsockets.mk
> +++ b/package/libwebsockets/libwebsockets.mk
> @@ -59,4 +59,8 @@ ifeq ($(BR2_SHARED_LIBS),y)
>  LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_STATIC=OFF
>  endif
>  
> +ifeq ($(BR2_PACKAGE_LIBWEBSOCKETS_INCLUDE_UNIX_SOCK),y)
> +LIBWEBSOCKETS_CONF_OPTS += -DLWS_UNIX_SOCK=ON
> +endif

We like to have an else clause that explicitly disable the option:

    else
    LIBWEBSOCKETS_CONF_OPTS += -DLWS_UNIX_SOCK=OFF
    endif

Indeed the default value may change when the version is bumped, which is
actually what hapenned with this option between 3.2.2 (currently in
Buildroot), and what they currently have in master (commit 911898ad7).

However, in this case, an option is not even needed: the size increase
is a mere 12 bytes:

    $ ls -l output-nosock/target/usr/lib/libwebsockets.so.15
    -rwxr-xr-x 1 ymorin ymorin 183292 Jun 14 10:13 output-nosock/target/usr/lib/libwebsockets.so.15

    $ ls -l output-sock/target/usr/lib/libwebsockets.so.15
    -rwxr-xr-x 1 ymorin ymorin 183304 Jun 14 10:15 output-sock/target/usr/lib/libwebsockets.so.15

So this does not even warrant an option to start with.

Applied with the option removed, thanks.

Regards,
Yann E. MORIN.

>  $(eval $(cmake-package))
> -- 
> 2.26.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2020-06-14  8:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-12 11:31 [Buildroot] [PATCH] package/libwebsockets: Add support for unix-domain-sockets Heiko Stuebner
2020-06-14  8:21 ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200614082104.GE2346@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox