Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] uclibc: add simlinks from libdl/libm/libpthread/librt
Date: Sun, 14 Jun 2020 17:00:21 +0200	[thread overview]
Message-ID: <20200614150021.GU2346@scaer> (raw)
In-Reply-To: <20200613162001.154280-1-paul@crapouillou.net>

Paul, All,

On 2020-06-13 18:20 +0200, Paul Cercueil spake thusly:
> All the symbols that were previously present in libdl.so.0, libm.so.0,
> libpthread.so.0 and librt.so.0 are now all packed within uClibc.
> 
> In order to keep binary compatibility with old executables, which were
> dynamically linked with one of the libraries above, add symbolic links
> to the uClibc shared library.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
>  package/uclibc/uclibc.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/uclibc/uclibc.mk b/package/uclibc/uclibc.mk
> index 3ba4589672..73664d5b0b 100644
> --- a/package/uclibc/uclibc.mk
> +++ b/package/uclibc/uclibc.mk
> @@ -424,6 +424,10 @@ define UCLIBC_INSTALL_TARGET_CMDS
>  		RUNTIME_PREFIX=/ \
>  		install_runtime
>  	$(UCLIBC_INSTALL_UTILS_TARGET)
> +	ln -sf libuClibc-$(UCLIBC_VERSION).so $(TARGET_DIR)/lib/libdl.so.0
> +	ln -sf libuClibc-$(UCLIBC_VERSION).so $(TARGET_DIR)/lib/libm.so.0
> +	ln -sf libuClibc-$(UCLIBC_VERSION).so $(TARGET_DIR)/lib/libpthread.so.0
> +	ln -sf libuClibc-$(UCLIBC_VERSION).so $(TARGET_DIR)/lib/librt.so.0

This does not account for external toolchains.

I wonder how good those symlinks are anyway: uClibc has no ABI/API
stability anyway, so there are no guarantee that a program linked
against a version of uClibc will work against another version, or even
the same version that was compiled with another configuration...

And I am not sure we want to condone such a case.

My opinion would be that, if you really need those legacy symlinks,
then you should create them in a post-build script.

I'm leaving this patch opened in patchwork, so other maintainers may
reverse my position.

Regards,
Yann E. MORIN.

>  endef
>  
>  # STATIC has no ld* tools, only getconf
> -- 
> 2.27.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2020-06-14 15:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-13 16:20 [Buildroot] [PATCH] uclibc: add simlinks from libdl/libm/libpthread/librt Paul Cercueil
2020-06-14 15:00 ` Yann E. MORIN [this message]
2020-06-14 17:51   ` Paul Cercueil
2020-06-21  8:51     ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200614150021.GU2346@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox