From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/7] package/dejavu: Install dejavu fonts in staging dir
Date: Sat, 20 Jun 2020 22:29:33 +0200 [thread overview]
Message-ID: <20200620222933.16376fca@windsurf.home> (raw)
In-Reply-To: <20200619145719.2352019-2-angelo@amarulasolutions.com>
Hello Angelo,
On Fri, 19 Jun 2020 16:57:13 +0200
Angelo Compagnucci <angelo@amarulasolutions.com> wrote:
> From: Michael Trimarchi <michael@amarulasolutions.com>
>
> The dejavu font is used by cups-filters and needs to be
> installed in staging directory.
>
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
The question is why should we do this just for the DejaVu fonts ? And
not other font packages ?
> +define DEJAVU_INSTALL_STAGING_CMDS
> + mkdir -p $(STAGING_DIR)/usr/share/fonts/dejavu/
> + for i in $(DEJAVU_FONTS_INSTALL) ; do \
> + $(INSTALL) -m 0644 $(@D)/ttf/$$i \
> + $(STAGING_DIR)/usr/share/fonts/dejavu/ || exit 1 ; \
> + done
> +endef
> +
> define DEJAVU_INSTALL_TARGET_CMDS
> mkdir -p $(TARGET_DIR)/usr/share/fonts/dejavu/
> for i in $(DEJAVU_FONTS_INSTALL) ; do \
We could factorize things a bit between staging/target installation,
and perhaps use a make "foreach" loop (if that works). But really these
are minor details, the main question is: why DejaVu specifically.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-06-20 20:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 14:57 [Buildroot] [PATCH v2 0/7] Cups revamp Angelo Compagnucci
2020-06-19 14:57 ` [Buildroot] [PATCH v2 1/7] package/dejavu: Install dejavu fonts in staging dir Angelo Compagnucci
2020-06-20 20:29 ` Thomas Petazzoni [this message]
2020-06-20 20:37 ` Michael Nazzareno Trimarchi
2020-06-19 14:57 ` [Buildroot] [PATCH v2 2/7] package/cups-filters: bump to version 1.27.5 Angelo Compagnucci
2020-06-20 20:33 ` Thomas Petazzoni
2020-06-20 20:42 ` Michael Nazzareno Trimarchi
2020-06-20 20:53 ` Thomas Petazzoni
2020-06-19 14:57 ` [Buildroot] [PATCH v2 3/7] package/cups: bump to version 2.3.3 Angelo Compagnucci
2020-06-20 20:35 ` Thomas Petazzoni
2020-06-20 20:48 ` Angelo Compagnucci
2020-06-20 20:55 ` Thomas Petazzoni
2020-06-20 21:53 ` Angelo Compagnucci
2020-06-21 12:10 ` Thomas Petazzoni
2020-06-19 14:57 ` [Buildroot] [PATCH v2 4/7] package/cups: Add lp user as default cups user Angelo Compagnucci
2020-06-20 20:37 ` Thomas Petazzoni
2020-06-19 14:57 ` [Buildroot] [PATCH v2 5/7] package/cups: Add udev rules to assign usb printers group to lp Angelo Compagnucci
2020-06-20 20:39 ` Thomas Petazzoni
2020-06-19 14:57 ` [Buildroot] [PATCH v2 6/7] package/cups: adding python support Angelo Compagnucci
2020-06-19 14:57 ` [Buildroot] [PATCH v2 7/7] package/qt5: Enable cups support when BR2_PACKAGE_CUPS Angelo Compagnucci
2020-06-20 20:47 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200620222933.16376fca@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox