From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/libxmlrpc: add openssl optional dependency
Date: Mon, 22 Jun 2020 22:25:08 +0200 [thread overview]
Message-ID: <20200622202508.GT2351@scaer> (raw)
In-Reply-To: <20200622054708.1885805-1-fontaine.fabrice@gmail.com>
On 2020-06-22 07:47 +0200, Fabrice Fontaine spake thusly:
> Without this patch, openssl_abyss is enabled if openssl is built before
> libxmlrpc
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/libxmlrpc/libxmlrpc.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/package/libxmlrpc/libxmlrpc.mk b/package/libxmlrpc/libxmlrpc.mk
> index 54db9f1f89..f9925b74ca 100644
> --- a/package/libxmlrpc/libxmlrpc.mk
> +++ b/package/libxmlrpc/libxmlrpc.mk
> @@ -39,6 +39,13 @@ ifeq ($(BR2_STATIC_LIBS),y)
> LIBXMLRPC_STATIC_OPTS = SHARED_LIB_TYPE=NONE MUST_BUILD_SHLIB=N
> endif
>
> +ifeq ($(BR2_PACKAGE_OPENSSL),y)
> +LIBXMLRPC_DEPENDENCIES = host-pkgconf openssl
> +LIBXMLRPC_CONF_OPTS = --enable-abyss-openssl
> +else
> +LIBXMLRPC_CONF_OPTS = --disable-abyss-openssl
> +endif
These should have been append-assignment, using '+=' not '='. This would
have been caught by rinning check-package:
$ make check-package
package/libxmlrpc/libxmlrpc.mk:43: conditional override of variable LIBXMLRPC_DEPENDENCIES
package/libxmlrpc/libxmlrpc.mk:44: conditional override of variable LIBXMLRPC_CONF_OPTS
package/libxmlrpc/libxmlrpc.mk:46: conditional override of variable LIBXMLRPC_CONF_OPTS
Regards,
Yann E. MORIN.
> LIBXMLRPC_MAKE_OPTS += $(LIBXMLRPC_STATIC_OPTS)
> LIBXMLRPC_INSTALL_STAGING_OPTS = $(LIBXMLRPC_STATIC_OPTS) \
> DESTDIR=$(STAGING_DIR) install
> --
> 2.26.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2020-06-22 20:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 5:47 [Buildroot] [PATCH 1/1] package/libxmlrpc: add openssl optional dependency Fabrice Fontaine
2020-06-22 9:07 ` Peter Korsgaard
2020-06-22 20:25 ` Yann E. MORIN [this message]
2020-07-16 15:03 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622202508.GT2351@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox