From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/libnids: new package
Date: Tue, 23 Jun 2020 14:24:24 +0200 [thread overview]
Message-ID: <20200623142424.5b6fc774@windsurf.home> (raw)
In-Reply-To: <CAJe0E3dU52qyQ_=eVN+1xtD8b1Kiwe=RZ7zvjpYfhZ8CDJinfQ@mail.gmail.com>
Hello,
On Tue, 23 Jun 2020 11:01:30 +0200
Guillaume Bres <guillaume.bressaix@gmail.com> wrote:
> Let's say I introduce a "BR2_PACKAGE_LIBNIDS_WITH_LIBNET" option,
As you discovered and replied later in the thread, don't add a
sub-option: simply check in the .mk file if BR2_PACKAGE_LIBDNET is
enabled.
> if I add a 0002-patch to also have libnet checked with pkg-config,
> Is it fine with you having a patch always applied, even though we are in
> the --disable-libnet context?
The patches should always all be applied. In theory, all patches are
supposed to be submitted to the upstream project, and the upstream
project will not conditionally apply the patch depending on whether
libnet support is enabled or not.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2020-06-23 12:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 10:53 [Buildroot] [PATCH 1/1] package/libnids: new package Guillaume W. Bres
2020-06-22 20:27 ` Thomas Petazzoni
2020-06-23 9:01 ` Guillaume Bres
2020-06-23 9:07 ` Guillaume Bres
2020-06-23 12:14 ` Guillaume Bres
2020-06-23 12:26 ` Thomas Petazzoni
2020-06-23 12:24 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200623142424.5b6fc774@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox