From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/libnids: disable libglib2 only if not available
Date: Tue, 23 Jun 2020 21:36:19 +0200 [thread overview]
Message-ID: <20200623193619.GZ2351@scaer> (raw)
In-Reply-To: <20200623183549.12105-1-guillaume.bressaix@gmail.com>
Guillaume, All,
On 2020-06-23 20:35 +0200, Guillaume W. Bres spake thusly:
> Take advantage of a possibly existing BR2_PACKAGE_LIBGLIB2
>
> Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
Thanks, applied to master, with the following changes:
- add missing dependency on libglib2
- expand commit log to explain why we don't --enable-libglib
- add a simmilar blurb in the .mk
- fix condition, use positive logic since we have an else-clause
Please see the resulting commit for inspiration for your future
contributions! ;-)
Regards,
Yann E. MORIN.
> ---
> package/libnids/libnids.mk | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/package/libnids/libnids.mk b/package/libnids/libnids.mk
> index ee7c71ee88..83719a712f 100644
> --- a/package/libnids/libnids.mk
> +++ b/package/libnids/libnids.mk
> @@ -12,8 +12,13 @@ LIBNIDS_INSTALL_STAGING = YES
> LIBNIDS_DEPENDENCIES = host-pkgconf libpcap
> LIBNIDS_AUTORECONF = YES
> LIBNIDS_CONF_OPTS = \
> - --disable-libglib \
> --disable-libnet
> +
> +# disable libglib2 if not available
> +ifeq ($(BR2_PACKAGE_LIBGLIB2),n)
> +LIBNIDS_CONF_OPTS += --disable-libglib
> +endif
> +
> # hand-written Makefile.in, not using automake, needs a custom
> # variable for the installation path.
> LIBNIDS_INSTALL_STAGING_OPTS = install_prefix=$(STAGING_DIR) install
> --
> 2.20.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2020-06-23 19:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 18:35 [Buildroot] [PATCH 1/1] package/libnids: disable libglib2 only if not available Guillaume W. Bres
2020-06-23 19:36 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200623193619.GZ2351@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox