From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/freescale-imx: Add option for all i.MX FW needs
Date: Wed, 24 Jun 2020 22:58:31 +0200 [thread overview]
Message-ID: <20200624225831.2183d1b0@windsurf> (raw)
In-Reply-To: <1593012228-18959-2-git-send-email-stephane.viau@oss.nxp.com>
Hello,
Thanks for doing this work! It's definitely bringing some good sanity
into this firmware-imx mess! See below some comments.
On Wed, 24 Jun 2020 17:23:47 +0200
Stephane Viau <stephane.viau@oss.nxp.com> wrote:
> diff --git a/package/freescale-imx/Config.in b/package/freescale-imx/Config.in
> index 0be37ce..2cac650 100644
> --- a/package/freescale-imx/Config.in
> +++ b/package/freescale-imx/Config.in
> @@ -12,40 +12,63 @@ choice
>
> config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX25_3STACK
> bool "imx25-3stack"
> + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW
>
> config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX27ADS
> bool "imx27ads"
> + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW
> + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY
>
> config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX37_3STACK
> bool "imx37-3stack"
> + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW
> + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY
>
> config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX50
> bool "imx50"
> + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW
> + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY
>
> config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX51
> bool "imx51"
> + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW
> + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY
>
> config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX53
> bool "imx53"
> + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW
> + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY
>
> config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6Q
> bool "imx6q/imx6dl"
> + select BR2_PACKAGE_FREESCALE_IMX_NEED_EPDC_FW
> + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW
> + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY
>
> config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6S
> bool "imx6sl/imx6sx"
> + select BR2_PACKAGE_FREESCALE_IMX_NEED_EPDC_FW
> + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW
> + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY
>
> config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6UL
> bool "imx6ul/imx6ull"
> + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW
> + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY
>
> config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX7
> bool "imx7d/imx7ulp"
> + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW
> + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY
>
> config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8
> bool "imx8"
> + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_IMX8_IMX8X
>
> config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M
> bool "imx8m"
> select BR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FW
> + select BR2_PACKAGE_FREESCALE_IMX_NEED_HDMI_FW
>
> config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MM
> bool "imx8mm"
> @@ -57,6 +80,7 @@ config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MN
>
> config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X
> bool "imx8x"
> + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_IMX8_IMX8X
> endchoice
>
> config BR2_PACKAGE_FREESCALE_IMX_PLATFORM
> @@ -102,6 +126,21 @@ config BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU
> config BR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FW
> bool
>
> +config BR2_PACKAGE_FREESCALE_IMX_NEED_EPDC_FW
> + bool
> +
> +config BR2_PACKAGE_FREESCALE_IMX_NEED_HDMI_FW
> + bool
> +
> +config BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW
> + bool
> +
> +config BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY
> + bool
> +
> +config BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_IMX8_IMX8X
> + bool
It would be nicer to use "NEEDS" instead of "NEED". That would require
a preparation patch that renames BR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FW
to BR2_PACKAGE_FREESCALE_IMX_NEEDS_DDR_FW.
However, I am wondering if package/freescale-imx/Config.in is the right
place for all this logic. After all, this is only related to the
firmware-imx package.
Shouldn't we instead move that to
package/freescale-imx/firmware-imx/Config.in, with the following form:
config BR2_PACKAGE_FREESCALE_IMX_NEEDS_DDR_FW
bool
default y if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M
default y if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MM
default y if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MN
and ditto the other options ? Here as well, it would require a
preparation patch to take care of the NEEDS_DDR_FW case, and then your
patch that handles all other FW files.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-06-24 20:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 15:23 [Buildroot] [PATCH 0/2] package/freescale-imx: clean-up proposal Stephane Viau
2020-06-24 15:23 ` [Buildroot] [PATCH 1/2] package/freescale-imx: Add option for all i.MX FW needs Stephane Viau
2020-06-24 19:54 ` Fabio Estevam
2020-06-24 20:11 ` Fabio Estevam
2020-06-24 20:26 ` Yann E. MORIN
2020-06-24 20:58 ` Thomas Petazzoni [this message]
2020-06-25 6:33 ` Stephane Viau
2020-06-25 20:33 ` Yann E. MORIN
2020-06-29 6:38 ` Stephane Viau
2020-06-29 8:32 ` Kurt Van Dijck
2020-06-29 8:08 ` Gary Bisson
2020-06-29 8:26 ` Stephane Viau
2020-06-24 15:23 ` [Buildroot] [PATCH 2/2] package/freescale-imx/firmware-imx: Clean up the image/target semantic Stephane Viau
2020-06-24 19:57 ` Fabio Estevam
2020-06-24 21:04 ` Thomas Petazzoni
2020-06-24 19:22 ` [Buildroot] [PATCH 0/2] package/freescale-imx: clean-up proposal Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200624225831.2183d1b0@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox