From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann E. MORIN Date: Thu, 25 Jun 2020 23:31:57 +0200 Subject: [Buildroot] [PATCH 1/1] rpi-firmware: do not rename startup files In-Reply-To: References: <20200624115009.15561-1-sveyret@gmail.com> <20200624165405.GA20645@scaer> <20200625182319.4cec8d94@gmx.net> <20200625192003.59506a9c@gmx.net> Message-ID: <20200625213157.GW20645@scaer> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net St?phane, All, On 2020-06-25 19:30 +0200, St?phane Veyret spake thusly: > > > Le jeu. 25 juin 2020 ? 18:23, Peter Seiderer a ?crit : > > > > > I think we should instead force the name of the startup files in the > > > > > config.txt (in package/rpi-firmware/config.txt): > > > > > start_file=start.elf > > > > > fixup_file=fixup.dat > > > > Or one step further, copy the start/fixup file verbatim and only change the > > > > start_file/fixup_file entry in config.txt (with the advantage to make it > > > > transparent which files are installed/in-use)... > > > If the file name is already the appropriate one (this is the first > > > version of my patch), using start_file and fixup_file is useless. And > > > I don't feel it is a good idea to set start_file and fixup_file if the > > > files already have expected names, because using these options is > > > discouraged: https://www.raspberrypi.org/documentation/configuration/config-txt/boot.md. > > The options are not discouraged, but 'advanced options' and should be handled with care ;-) > > The advantage of the explicit start_file/fixup_file entries is that it is clear/determined > > which files are used (instead of relaying on the RPi 'magic' depending on the combination > > of other options).... > OK, I understand. Yann, do you agree? Shall I create a v3 patch? I do agree that we better force the names of the file to load, yes. No, you do not need to send a v3, as I explained in my reply to Peter. I'll will probably apply your v2 patch as-is shortly... Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'