From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/minidlna: Fix FTBFS with gcc10
Date: Sat, 27 Jun 2020 21:26:24 +0200 [thread overview]
Message-ID: <20200627192624.GC20645@scaer> (raw)
In-Reply-To: <8e4ksgxalv.ln2@ID-313208.user.individual.net>
On 2020-06-27 17:15 +0200, Bernd Kuhls spake thusly:
> Am Sat, 27 Jun 2020 17:12:27 +0200 schrieb Thomas Petazzoni:
> > On Sat, 27 Jun 2020 13:43:14 +0200 Bernd Kuhls
> > <bernd.kuhls@t-online.de> wrote:
> >> Bug was reported upstream:
> >> https://sourceforge.net/p/minidlna/patches/182/
> > This bug doesn't seem at all to match this gcc10 build issue. Am I
> > missing something?
That's because setjmp_buffer is also declared in image_utils.c, and this
triggers the infamous gcc-10 -fno-common error.
> oops, added the wrong link, this is the right one:
> https://sourceforge.net/p/minidlna/support-requests/70/
Ah, but as I see it, both the proposal in that bug repot (addign extern
in front of one of them), or renaming the variable in metadata.c or in
mage_utils.c, are wrong.
The real fix is to turn both variables as static, so their scope is
limited to the file they are defined and use in.
Care to take that with upstream (and debian), please?
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2020-06-27 19:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-27 11:43 [Buildroot] [PATCH 1/1] package/minidlna: Fix FTBFS with gcc10 Bernd Kuhls
2020-06-27 15:12 ` Thomas Petazzoni
2020-06-27 15:15 ` Bernd Kuhls
2020-06-27 19:26 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200627192624.GC20645@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox