Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Olivain <juju@cotds.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/4] package/poco: add BR2_PACKAGE_POCO_ARCH_SUPPORTS
Date: Tue, 30 Jun 2020 19:34:32 +0200	[thread overview]
Message-ID: <20200630173435.7828-1-juju@cotds.org> (raw)
In-Reply-To: <20200629210735.179913-1-juju@cotds.org>

This change is motivated by a misalignment of the Kconfig package and
comment dependencies, introduced in commit 0737f48c5f "package/poco:
disable build for riscv" (BR_riscv was missing in the comment).
Introducing BR2_PACKAGE_POCO_ARCH_SUPPORTS solve this issue.

Signed-off-by: Julien Olivain <juju@cotds.org>
---
Changes v1 -> v2:
Suggested by Thomas:
  - introduce _ARCH_SUPPORTS to prevent duplicating dependency conditions
---
 package/poco/Config.in | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/package/poco/Config.in b/package/poco/Config.in
index f8f921de04..13f7b3b0a3 100644
--- a/package/poco/Config.in
+++ b/package/poco/Config.in
@@ -1,3 +1,8 @@
+config BR2_PACKAGE_POCO_ARCH_SUPPORTS
+	bool
+	default y if !(BR2_arc || BR2_microblaze || BR2_mipsel \
+		|| BR2_or1k || BR2_riscv || BR2_xtensa)
+
 config BR2_PACKAGE_POCO
 	bool "poco"
 	depends on BR2_INSTALL_LIBSTDCPP
@@ -5,8 +10,7 @@ config BR2_PACKAGE_POCO
 	# pthread_condattr_setclock
 	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
 	depends on !BR2_STATIC_LIBS # dlopen()
-	depends on !(BR2_arc || BR2_microblaze || BR2_mipsel \
-		|| BR2_or1k || BR2_riscv || BR2_xtensa)
+	depends on BR2_PACKAGE_POCO_ARCH_SUPPORTS
 	select BR2_PACKAGE_ZLIB
 	select BR2_PACKAGE_PCRE
 	help
@@ -85,5 +89,4 @@ endif # BR2_PACKAGE_POCO
 comment "poco needs a toolchain w/ wchar, NPTL, C++, dynamic library"
 	depends on !BR2_USE_WCHAR || !BR2_INSTALL_LIBSTDCPP \
 		|| !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
-	depends on !(BR2_arc || BR2_microblaze || BR2_mipsel \
-		|| BR2_or1k || BR2_xtensa)
+	depends on BR2_PACKAGE_POCO_ARCH_SUPPORTS
-- 
2.26.2

  parent reply	other threads:[~2020-06-30 17:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-29 21:07 [Buildroot] [PATCH 1/4] package/poco: fix the comment dependencies about riscv Julien Olivain
2020-06-29 21:07 ` [Buildroot] [PATCH 2/4] package/poco: bump to version 1.10.1 Julien Olivain
2020-06-29 21:18   ` Thomas Petazzoni
2020-06-29 21:07 ` [Buildroot] [PATCH 3/4] package/poco: enable build for riscv64 Julien Olivain
2020-06-29 21:19   ` Thomas Petazzoni
2020-06-29 21:07 ` [Buildroot] [PATCH 4/4] package/poco: add new option for the Poco JWT component Julien Olivain
2020-06-29 21:21   ` Thomas Petazzoni
2020-06-29 21:17 ` [Buildroot] [PATCH 1/4] package/poco: fix the comment dependencies about riscv Thomas Petazzoni
2020-06-30 17:34 ` Julien Olivain [this message]
2020-06-30 17:34   ` [Buildroot] [PATCH v2 2/4] package/poco: bump to version 1.10.1 Julien Olivain
2020-06-30 17:34   ` [Buildroot] [PATCH v2 3/4] package/poco: enable build for riscv64 Julien Olivain
2020-06-30 17:34   ` [Buildroot] [PATCH v2 4/4] package/poco: add new option for the Poco JWT component Julien Olivain
2020-06-30 20:15   ` [Buildroot] [PATCH v2 1/4] package/poco: add BR2_PACKAGE_POCO_ARCH_SUPPORTS Yann E. MORIN
2020-07-16 16:40   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200630173435.7828-1-juju@cotds.org \
    --to=juju@cotds.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox