From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/swig: enable support for Node.js >= 12.x
Date: Tue, 7 Jul 2020 22:26:44 +0200 [thread overview]
Message-ID: <20200707202644.GU2273@scaer> (raw)
In-Reply-To: <20200707051023.19992-1-yegorslists@googlemail.com>
Yegor, All,
On 2020-07-07 07:10 +0200, yegorslists at googlemail.com spake thusly:
> From: Yegor Yefremov <yegorslists@googlemail.com>
>
> Recent Node.js versions have removed some depreciated API calls,
> that swig still relies on. Patches taken from this PR [1] fix
> this issue.
>
> [1] https://github.com/swig/swig/pull/1746
>
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
> ...-to-support-both-Handle-and-Local-ty.patch | 53 ++
> ...ith-Local-depending-on-Node.js-versi.patch | 649 ++++++++++++++++++
> .../0003-Add-support-for-Node.js-v12.patch | 207 ++++++
> 3 files changed, 909 insertions(+)
> create mode 100644 package/swig/0001-Introduce-macros-to-support-both-Handle-and-Local-ty.patch
> create mode 100644 package/swig/0002-Replace-Handle-with-Local-depending-on-Node.js-versi.patch
> create mode 100644 package/swig/0003-Add-support-for-Node.js-v12.patch
So, few things:
1. I don't see how swig can use or detect nodejs, as you are not adding
a build dependency to host-nodejs;
2. this is a feature patch IMHO, and upstream has not even applied it
yet;
3. swig is a host-only package; why would we want it to have proper
nodejs support in Buildroot?
As such, this is a not for me so far. If upstream were to apply it, we
may consider a backport, as long as there is a use-case for it.
Consequently, I haven't even looked at that spacing problem you
noticed...
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2020-07-07 20:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 5:10 [Buildroot] [PATCH] package/swig: enable support for Node.js >= 12.x yegorslists at googlemail.com
2020-07-07 6:32 ` Yegor Yefremov
2020-07-07 16:43 ` Yegor Yefremov
2020-07-07 20:26 ` Yann E. MORIN [this message]
2020-07-08 14:34 ` Yegor Yefremov
2020-07-08 16:42 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707202644.GU2273@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox