From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] package/python-greenlet: fix build for i386 and x86_64 archs
Date: Tue, 7 Jul 2020 22:52:29 +0200 [thread overview]
Message-ID: <20200707205229.GW2273@scaer> (raw)
In-Reply-To: <20200707200431.181733-1-james.hilliard1@gmail.com>
On 2020-07-07 14:04 -0600, James Hilliard spake thusly:
> BR2_x86 doesn't exist in buildroot which should be BR2_i386.
>
> BR2_x86_64 was missed in 30f1decec2ca190deea072f4d490a8de830ac9a3.
So, these are twi different changes:
- the first is a fix, and should be its own patch, so it can be
backported to the latest stable branch, 2020.05.x
- the second is a new feature, enabling a new arch, so should be a
second, separate patch.
As a consequence, the commit log is misleading: we're not "fixing" build
for x86_64; instead, we're enabling it. And in all theory, wer're not
"fixing" the build for i386 either, because the build is not really
broken as there actually is no build going on...
I've split them, fixed commit logs, and applied to master, thanks
Regards,
Yann E. MORIN.
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> Changes v1 -> v2:
> - also fix BR2_i386
> ---
> package/python-greenlet/Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/python-greenlet/Config.in b/package/python-greenlet/Config.in
> index 44ab96b488..c73eeb7b15 100644
> --- a/package/python-greenlet/Config.in
> +++ b/package/python-greenlet/Config.in
> @@ -8,7 +8,7 @@ config BR2_PACKAGE_PYTHON_GREENLET_ARCH_SUPPORTS
> default y if BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le
> default y if BR2_riscv
> default y if BR2_sparc || BR2_sparc64
> - default y if BR2_x86
> + default y if BR2_i386 || BR2_x86_64
>
> config BR2_PACKAGE_PYTHON_GREENLET
> bool "python-greenlet"
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2020-07-07 20:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 20:04 [Buildroot] [PATCH v2 1/1] package/python-greenlet: fix build for i386 and x86_64 archs James Hilliard
2020-07-07 20:52 ` Yann E. MORIN [this message]
2020-07-07 21:38 ` James Hilliard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707205229.GW2273@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox